Re: [PATCH 04/11] multi-pack-index: verify packname order

From: Derrick Stolee <stolee@gmail.com>
Date: Sep 5, 2018, 19:11 UTC
Message-ID: <da7eaf92-57f6-8129-149d-4260d84b4eb0@gmail.com>
In-Reply-To: <CAGZ79kY7_RJfJomkpob85A4ubvXJt3BR8njkaozLgi-6ytxB9w@mail.gmail.com>

On 9/5/2018 2:15 PM, Stefan Beller wrote:

Show 13 quoted lines

> On Wed, Sep 5, 2018 at 7:46 AM Derrick Stolee via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
>> From: Derrick Stolee <dstolee@microsoft.com>
>>
>> The final check we make while loading a multi-pack-index is that
>> the packfile names are in lexicographical order. Make this error
>> be a die() instead.
> What is the advantage of having a die() here?
> Would the midx work under normal operation when
> not sorted correctly?
>
> This sounds like a hack for easy testability in this context,
> so could you clarify why this helps the regular user?

The multi-pack-index will not work as expected, since midx_contains_pack() may provide incorrect results, and thus we will add the "missing" packfiles to the packed_git linked list.

This _should_ be a die(), as something unexpected occurred (the file doesn't match the format specification).