Re: [PATCH] rev-list: clarify git-log default date format
- From
- Rafael Dulfer <rafael@dulfer.be>
- Date
- Feb 2, 2023, 11:37 UTC
- Message-ID
- <d9fc8688-bbf1-96c2-07bf-a12fe38625a9@dulfer.be>
- In-Reply-To
- <xmqqy1phxabi.fsf@gitster.g>
> Add "on day X at time Y" here, and I'd buy that 😉
Feels to me that adding "on day X at time Y" is a bit superfluous, since it's quite obvious from the examples, but I guess it can't hurt to be exact.
I think it would be a good idea to still have _some_ text for `--date=default`, just so the structure of the sections stays the same over all the date options. Maybe just something simple like. "`--date=default` is the default format. It is a custom format based on rfc2822". And then below that we have the table (which is more a conclusion to the section, as it provides examples for a few, more unclear, formats)
On 01/02/2023 23:58, Junio C Hamano wrote:
Show 25 quoted lines
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes: > >>> That is >>> >>> The default format `--date=default` shows a single line with >>> three-letter day of the week, three-letter month, day-of-month, >>> hour-minute-second in the "HH:MM:SS" format, followed by 4-digit >>> year, plus timezone information unless the local time zone is >>> used (e.g. "Thu Jan 1 00:00:00 1970 +0000"). >>> >>> or something like that. >> I think that following such a description in prose is still more >> confusing than just showing an example. E.g. we could say: >> >> Assuming a user in timezone +0200 (Central Europe) values of > Add "on day X at time Y" here, and I'd buy that ;-) > >> these `--date` argument would produce: >> >> |---------------+--------------------------------| >> | rfc2822 | Thu, 7 Apr 2005 15:13:13 -0700 | >> | rfc2822-local | Fri, 8 Apr 2005 00:13:13 +0200 | >> | default | Thu Apr 7 15:13:13 2005 -0700 | >> | default-local | Fri Apr 8 00:13:13 2005 | >> |---------------+--------------------------------|