git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] compat/terminal: mark parameter of git_terminal_prompt() UNUSED

From
Ramsay Jones <ramsay@ramsayjones.plus.com>
Date
Aug 29, 2024, 21:57 UTC
Message-ID
<d8c5e920-aff7-4e4b-af77-0d3193466b57@ramsayjones.plus.com>
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi,

The 'seen' branch fails to compile on cygwin (but its fine on Linux), due to an unused parameter. I haven't looked too hard at the code (at first blush, it seemed to me that it should not even be trying to compile that code, but ...), I simply added an UNUSED to fix the build. ;)

So, this may not be the correct 'fix' for this, but I thought I should report it here, since I don't have time to look into this now. sorry! :(

ATB, Ramsay Jones

 compat/terminal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/compat/terminal.c b/compat/terminal.c
index 0afda730f2..d54efa1c5d 100644
--- a/compat/terminal.c
+++ b/compat/terminal.c
@@ -594,7 +594,7 @@ void restore_term(void)
 {
 }
 
-char *git_terminal_prompt(const char *prompt, int echo)
+char *git_terminal_prompt(const char *prompt, int echo UNUSED)
 {
 	return getpass(prompt);
 }
-- 
2.46.0
Next: Jeff King
Message 1 of 4 in “compat/terminal: mark parameter of git_terminal_prompt() UNUSED”
  1. compat/terminal: mark parameter of git_terminal_prompt() UNUSEDRamsay Jones, Aug 29, 2024
  2. Jeff KingAug 29, 2024
  3. Ramsay JonesAug 31, 2024
  4. Jeff KingAug 31, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.