Re: [PATCH v3 1/2] add -p: mark split hunks as undecided
- From
- Phillip Wood <phillip.wood123@gmail.com>
- Date
- Oct 8, 2025, 13:51 UTC
- Message-ID
- <d7ac0aab-9363-44b3-8ced-28d1693fd85c@gmail.com>
- In-Reply-To
- <xmqqseg9azdc.fsf@gitster.g>
On 26/09/2025 18:37, Junio C Hamano wrote:
Show 18 quoted lines
> Phillip Wood <phillip.wood123@gmail.com> writes: >> On 25/09/2025 19:21, Junio C Hamano wrote: >>> "Phillip Wood via GitGitGadget" <gitgitgadget@gmail.com> writes: >>> So I like the updated behaviour very much, but I am reluctant to >>> pretend as if we are siding one camps of folks who think that >>> splitting a selected hunk is done with an intention to deselect most >>> of the minihunks most of the time, playing favors. I think that >>> is a wrong way to frame the problem this patch solved. >>> In any case, I no longer have problems with the updated behaviour >>> with these two patches. Thanks for working on them. >>> Will queue. >> >> Thanks, do you want a different commit message or are you happy to >> take them as-is? > > Hmph, what would an improved commit log message would say? Reword > the second UI problem above and explain how this change improves the > situation?
Yes. Having said that I'm about to go off the list until the middle of the week after next so maybe we should settle for what we've got.
Thanks
Phillip