Re: [PATCH v3 0/1] [BUG] refs: verify does not work if there are v2.43.0 or older worktrees w/o wt. refs

From: Kristoffer Haugsbakk <code@khaugsbakk.name>
Date: Jun 2, 2025, 15:01 UTC
Message-ID: <d7265bca-ac47-4610-834d-da91042ccdf0@app.fastmail.com>
In-Reply-To: <aD23w6-szFjKQGSj@ArchLinux>

On Mon, Jun 2, 2025, at 16:40, shejialuo wrote:

Show 29 quoted lines

> [snip]
>
> Range-diff against v2:
> 1:  d949a8a646 ! 1:  e4c32971da fsck: ignore missing "refs" directory
> for linked worktrees
>     @@ t/t0602-reffiles-fsck.sh: test_expect_success 'ref name check
> should be adapted
>      +		test_commit initial &&
>      +		git worktree add --detach ./worktree &&
>      +
>     -+		cd worktree &&
>     -+		worktree_refdir="$(git rev-parse --git-dir)/refs" &&
>     -+		# Simulate old directory layout
>     -+		rmdir "$worktree_refdir" &&
>     -+		git refs verify 2>err &&
>     -+		test_must_be_empty err
>     ++		(
>     ++			cd worktree &&
>     ++			worktree_refdir="$(git rev-parse --git-dir)/refs" &&
>     ++			# Simulate old directory layout
>     ++			rmdir "$worktree_refdir" &&
>     ++			git refs verify 2>err &&
>     ++			test_must_be_empty err
>     ++		)
>      +	)
>      +'
>      +
> --
> 2.49.0

This version works as well.  Thanks!

    $ git range-diff --no-color --no-notes --inter-hunk-context=1 --ignore-all-space <range>
    1:  ddbf0f8cf4c ! 1:  ce802ef6698 fsck: ignore missing "refs" directory for linked worktrees
        @@ t/t0602-reffiles-fsck.sh: test_expect_success 'ref name check should be adapted
         +          test_commit initial &&
         +          git worktree add --detach ./worktree &&
         +
        ++          (
         +                  cd worktree &&
         +                  worktree_refdir="$(git rev-parse --git-dir)/refs" &&
         +                  # Simulate old directory layout
         +                  rmdir "$worktree_refdir" &&
         +                  git refs verify 2>err &&
         +                  test_must_be_empty err
         +          )
        ++  )
         +'
         +
          test_expect_success 'ref name check should work for multiple worktrees' '