git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] diff --stat: clean up unused code

From
Aapodtele <apodtele@gmail.com>
Date
Oct 12, 2006, 19:40 UTC
Message-ID
<d620685f0610121240h85d7a6eq2e3a2cf66a7643c5@mail.gmail.com>
Clean up unused code.
Signed-off-by: Alexei Podtelezhnikov

--- diff.c 2006-10-12 15:07:30.000000000 -0400 +++ diff.c 2006-10-12 15:17:15.000000000 -0400

@@ -660,8 +660,8 @@

 static void show_stats(struct diffstat_t* data, struct diff_options *options)
 {
-	int i, len, add, del, total, adds = 0, dels = 0;
-	int max_change = 0, max_len = 0;
+	int i, len, add, del, adds = 0, dels = 0;
+	int max_len = 0;
 	int total_files = data->nr;
 	int width, name_width;
 	const char *reset, *set, *add_c, *del_c;
@@ -706,8 +706,6 @@

 		if (file->is_binary || file->is_unmerged)
 			continue;
-		if (max_change < change)
-			max_change = change;
 	}

 	/* Compute the width of the graph part;
@@ -718,10 +716,7 @@
 	 * and width is the width of the graph area.
 	 */
 	name_width = (name_width < max_len) ? name_width : max_len;
-	if (width < (name_width + 10) + max_change)
-		width = width - (name_width + 10);
-	else
-		width = max_change;
+	width = width - (name_width + 10);

 	for (i = 0; i < data->nr; i++) {
 		const char *prefix = "";
@@ -766,13 +761,11 @@
 		 */
 		add = added;
 		del = deleted;
-		total = add + del;
 		adds += add;
 		dels += del;

 		add = scale_nonlinear(add, width / 2);
 		del = scale_nonlinear(del, width / 2);
-		total = add + del;
 		show_name(prefix, name, len, reset, set);
 		printf("%5d ", added + deleted);
 		show_graph('+', add, add_c, reset);
Message 1 of 1 in “diff --stat: clean up unused code”
  1. 2/2 diff --stat: clean up unused codeapodtele, Oct 12, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.