[PATCH v2] Mark win32's pthread_exit() as NORETURN
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Mar 1, 2016, 14:13 UTC
- Message-ID
- <d584d8bdaa8645a406c96f2a11f04febf57b2c25.1456841593.git.johannes.schindelin@gmx.de>
- In-Reply-To
- <69eef72cfc77e62ad7ad17c6df5f2d2396c64991.1456840324.git.johannes.schindelin@gmx.de>
The pthread_exit() function is not expected to return. Ever. On Windows, we call ExitThread() whose documentation claims: "This function does not return a value.":
https://msdn.microsoft.com/en-us/library/windows/desktop/ms682659
Pointed out by Jeff King.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> ---
Relative to v1, only the commit message changed (to clarify that ExitThread() indeed never returns).
compat/win32/pthread.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/compat/win32/pthread.h b/compat/win32/pthread.h index 20b35a2..148db60 100644 --- a/compat/win32/pthread.h +++ b/compat/win32/pthread.h @@ -78,7 +78,7 @@ extern int win32_pthread_join(pthread_t *thread, void **value_ptr); #define pthread_equal(t1, t2) ((t1).tid == (t2).tid) extern pthread_t pthread_self(void); -static inline int pthread_exit(void *ret) +static inline int NORETURN pthread_exit(void *ret) { ExitThread((DWORD)(intptr_t)ret); }
-- 2.7.2.windows.1.5.g64acc33