Re: [PATCH 3/6] doc: notes: split out options with negations
- From
Kristoffer Haugsbakk <code@khaugsbakk.name>
- Date
- May 21, 2025, 14:42 UTC
- Message-ID
- <d4491de5-9482-4bd1-9fca-dd960a815f51@app.fastmail.com>
- In-Reply-To
- <xmqqsekyds2e.fsf@gitster.g>
On Wed, May 21, 2025, at 15:14, Junio C Hamano wrote:
Show 14 quoted lines
>> Together with the post context lines, it is unclear what the default >> behaviour is for the command. It is not a new problem, but >> hopefully the remaining 3 patches I haven't read would address it? > > I guess this was left unresolved after the series, but it is > perfectly fine to leave it outside the topic. Somebody else may > want to look into how exactly stripspace behaviour works by default > and how this option affects [*] and document it here. > > [Footnote] > > * IIRC, we made the default to strip, unless the message came from > an existing note in which case it is left intact; but whoever > does the documentation update should check it.
Good point. I looked over the options for any ambiguity but missed this one.
I’ll fix it on a separate patch in the next version.
-- Kristoffer