git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] rebase-interactive.h: fix hdr-check warnings

From
Ramsay Jones <ramsay@ramsayjones.plus.com>
Date
Jan 13, 2019, 21:00 UTC
Message-ID
<d414e1a2-e5a1-ce15-96b5-cf294c7f3c92@ramsayjones.plus.com>
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Alban,

If you need to re-roll your 'ag/sequencer-reduce-rewriting-todo' branch, could you please squash this into the relevant patch [commit c27b32f0ec4 ("sequencer: refactor check_todo_list() to work on a todo_list", 2018-12-29)].

[Both commit e5b1c9d9299 and c27b32f0ec4 add function declarations that cause the hdr-check target to complain about the lack of a declaration for 'struct todo_list'. However, c27b32f0ec4 is earlier in the branch ...].

Thanks!

ATB, Ramsay Jones

 rebase-interactive.h | 1 +
 1 file changed, 1 insertion(+)
diff --git a/rebase-interactive.h b/rebase-interactive.h
index 42cc3f865d..44dbb06311 100644
--- a/rebase-interactive.h
+++ b/rebase-interactive.h
@@ -3,6 +3,7 @@
 
 struct strbuf;
 struct repository;
+struct todo_list;
 
 void append_todo_help(unsigned keep_empty, int command_count,
 		      const char *shortrevisions, const char *shortonto,
-- 
2.20.0
Message 1 of 1 in “rebase-interactive.h: fix hdr-check warnings”
  1. rebase-interactive.h: fix hdr-check warningsRamsay Jones, Jan 13, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.