Re: [PATCH v4] fsmonitor OSX: fix hangs for submodules

From: Ramsay Jones <ramsay@ramsayjones.plus.com>
Date: Oct 4, 2024, 18:47 UTC
Message-ID: <d350d598-fc99-4384-b2d5-5cc898a17c12@ramsayjones.plus.com>
In-Reply-To: <xmqqiku7epa7.fsf@gitster.g>

On 04/10/2024 18:44, Junio C Hamano wrote:

Show 19 quoted lines

> "Koji Nakamaru via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
>> ... The test is
>> disabled for MINGW because hangs treated with this patch occur only for
>> Darwin and there is no simple way to terminate the win32 fsmonitor
>> daemon that hangs.
>> ...
>>      @@ t/t7527-builtin-fsmonitor.sh: test_expect_success "submodule absorbgitdirs impli
>>       +	done
>>       +}
>>       +
>>      -+test_expect_success "submodule implicitly starts daemon by pull" '
>>      ++test_expect_success !MINGW "submodule implicitly starts daemon by pull" '
>>       +	test_atexit "stop_watchdog" &&
>>       +	test_when_finished "stop_git; rm -rf cloned super sub" &&
>>       +
> 
> Let me update !MINGW to !WINDOWS while queuing.
>

While this won't hurt, this test file is skipped on cygwin:

[23:19:33] t7527-builtin-fsmonitor.sh ......................... skipped: fsmonitor--daemon is not supported on this platform

(my eternal TODO list has an 'fsmonitor on cygwin?' item ...)

Thanks.

ATB, Ramsay Jones