Re: [PATCH] MSVC: fix build warnings
- From
Michael Wookey <michaelwookey@gmail.com>
- Date
- Oct 5, 2009, 05:38 UTC
- Message-ID
- <d2e97e800910042238t3ba02d59ud4e7f5b3b2b11183@mail.gmail.com>
- In-Reply-To
- <7v7hvak1ec.fsf@alter.siamese.dyndns.org>
2009/10/5 Junio C Hamano <gitster@pobox.com>:
Show 7 quoted lines
> Michael Wookey <michaelwookey@gmail.com> writes: > >> I can't build with -Werror on Ubuntu 9.04 (gcc 4.3.3) because of the following: >> >> http://article.gmane.org/gmane.comp.version-control.git/127477 > > I think that has been fixed already while I was away ;-)
I still get the warning with the current git.git:master (dbc1b1f7) and git.git:next (8ea19b84). Would you consider taking the original patch to fix the build warning? Perhaps I should resend the patch as a "partial revert" of eb3a9dd which introduced this warning as described here:
http://article.gmane.org/gmane.comp.version-control.git/127519
What do you think?