Re: [PATCH] filter-branch: use printf instead of echo -e
- From
Michele Locati <michele@locati.it>
- Date
- Mar 20, 2018, 10:21 UTC
- Message-ID
- <d2bf28a9-ae79-9046-22f4-ceac502882f6@locati.it>
- In-Reply-To
- <1521539621.2474.60.camel@hellion.org.uk>
Il 20/03/2018 10:53, Ian Campbell ha scritto:
Show 12 quoted lines
> On Tue, 2018-03-20 at 00:22 -0400, Jeff King wrote: >> Author cc'd in case there's something more interesting going on. > > That code was written years ago, if I had a good reason at the time > I've forgotten what it was and I can't think of a fresh one now. > Switching to printf seems like a reasonable thing to do. > > Perhaps switch the remaining `/bin/echo` (there are two without `-e`) > uses to just `echo` for consistency with the rest of the file? > > Ian. >
Thanks for reply, Ian. Charles already suggested to replace /bin/echo with echo, and I already updated the patch accordingly: see https://marc.info/?l=git&m=152147479517707&w=2 Junio already queued that PATCH-v2.
-- Michele