git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix memory leak in get_reachable_subset

From
Derrick Stolee <derrickstolee@github.com>
Date
Apr 24, 2023, 15:21 UTC
Message-ID
<d2825134-61db-9da4-450c-f027117b3d48@github.com>
In-Reply-To
<20230421234409.1925489-1-mh@glandium.org>
On 4/21/2023 7:44 PM, Mike Hommey wrote:
Show 6 quoted lines
> @@ -944,6 +944,8 @@ struct commit_list *get_reachable_subset(struct commit **from, int nr_from,
>  		}
>  	}
>  
> +	clear_prio_queue(&queue);
> +

Thanks. This is a leak that has existed since the method was first created in fcb2c0769db (commit-reach: implement get_reachable_subset, 2018-11-02). I appreciate the attention to detail.

-Stolee
Previous: Mike HommeyNext: Junio C Hamano
Message 2 of 4 in “Fix memory leak in get_reachable_subset”
  1. Fix memory leak in get_reachable_subsetMike Hommey, Apr 21, 2023
  2. Derrick StoleeApr 24, 2023
  3. Junio C HamanoApr 24, 2023
  4. Mike HommeyApr 24, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.