Re: [PATCH] send-email: avoid duplicate In-Reply-To/References
- From
Stefan Agner <stefan@agner.ch>
- Date
- Apr 18, 2018, 07:38 UTC
- Message-ID
- <d218005b0c44b7f8a61c82d060352eee@agner.ch>
- In-Reply-To
- <20180418005415.GA31588@dcvr>
On 18.04.2018 02:54, Eric Wong wrote:
Show 21 quoted lines
> Stefan Agner <stefan@agner.ch> wrote:
>> This addresses the issue reported here:
>> https://public-inbox.org/git/997160314bbafb3088a401f1c09ccb08@agner.ch/
>
> Thanks for bringing this up.
>
>> --- a/git-send-email.perl
>> +++ b/git-send-email.perl
>> @@ -1642,10 +1642,15 @@ foreach my $t (@files) {
>> elsif (/^Content-Transfer-Encoding: (.*)/i) {
>> $xfer_encoding = $1 if not defined $xfer_encoding;
>> }
>> + elsif (/^In-Reply-To: (.*)/i) {
>> + $in_reply_to = $1;
>> + }
>> + elsif (/^References: (.*)/i) {
>> + $references = $1;
>> + }
>
> References: can span multiple lines with --thread=deep in format-patch
> (technically any header can be, but References: is common)I think that is ok because we do # First unfold multiline header fields
...
A quick test with 3 patches in --thread=deep mode looks good: In-Reply-To: <87d48c04aae0594ebea7567827d08979ad346380.1524034203.git.stefan@agner.ch> References: <06ea66574abfb2dd66adee9996e5fb66903b95a3.1524034203.git.stefan@agner.ch> <87d48c04aae0594ebea7567827d08979ad346380.1524034203.git.stefan@agner.ch>
-- Stefan