Re: tb/commit-graph-genv2-upgrade-fix

From: Derrick Stolee <derrickstolee@github.com>
Date: Jul 26, 2022, 11:29 UTC
Message-ID: <d1d460f6-e70f-b17f-73a5-e56d604dd9d5@github.com>
In-Reply-To: <Yt8RcDeSht56gU5v@nand.local>

On 7/25/22 5:56 PM, Taylor Blau wrote:

Show 17 quoted lines

> On Fri, Jul 22, 2022 at 06:01:10PM -0700, Junio C Hamano wrote:
>> * tb/commit-graph-genv2-upgrade-fix (2022-07-15) 3 commits
>>  - commit-graph: fix corrupt upgrade from generation v1 to v2
>>  - commit-graph: introduce `repo_find_commit_pos_in_graph()`
>>  - t5318: demonstrate commit-graph generation v2 corruption
>>
>>  There was a bug in the codepath to upgrade generation information
>>  in commit-graph from v1 to v2 format, which has been corrected.
>>
>>  Will merge to 'next'?
>>  source: <cover.1657667404.git.me@ttaylorr.com>
> 
> Yeah, I think that this one is ready to go. It's the minimal fix I would
> consider acceptable for squashing this bug, but it should do what we
> need.
> 
> Stolee gave it a positive review, and I doubt he has any objections.

I agree that this is ready for 'next'.

Thanks, -Stolee