git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[GSOC PATCH v5 0/2] commit: improve behaviour of core.commentChar=auto for comments in commit messages

From
Ayush Chandekar <ayu.chandekar@gmail.com>
Date
Jul 16, 2025, 11:43 UTC
Message-ID
<cover.1752665506.git.ayu.chandekar@gmail.com>
In-Reply-To
<20250626132233.414789-1-ayu.chandekar@gmail.com>
Hey everyone,

The aim of this patch series is to improve the behaviour of core.commentChar=auto by the following patches: 1/2 - Fix a bug which reads comment character of the comments in commit message leading to change in the value of `comment_line_str` and thus resulting the comments in the final commit message. 2/2 - Standardizes the behaviour of code by resetting the 'comment_line_str' to "#" when 'core.commentChar' is set to "auto".

Thanks to Junio, Phillip and Kristoffer for reviewing the patches and also Christian for the reviews and mentoring me.
The only difference between this version (v5) and the previous one is that I've added credit to Phillip for patch (2/2).
Ayush Chandekar (2):
  commit: avoid scanning trailing comments when 'core.commentChar' is
    "auto"
  config: set comment_line_str to "#" when core.commentChar=auto
 builtin/commit.c           |  6 +++++-
 config.c                   |  6 ++++--
 t/t3418-rebase-continue.sh | 13 +++++++++++++
 3 files changed, 22 insertions(+), 3 deletions(-)
-- 
2.49.0
Previous: Junio C HamanoNext: Ayush Chandekar
Message 36 of 41 in “commit: avoid scanning trailing comments when 'core.commentChar' is "auto"”
  1. commit: avoid scanning trailing comments when 'core.commentChar' is "auto"Ayush Chandekar, Jun 26, 2025
  2. Junio C HamanoJun 26, 2025
  3. Ayush ChandekarJun 26, 2025
  4. Kristoffer HaugsbakkJun 26, 2025
  5. Ayush ChandekarJun 26, 2025
  6. commit: avoid scanning trailing comments when 'core.commentChar' is "auto"Ayush Chandekar, Jun 26, 2025
  7. Phillip WoodJun 27, 2025
  8. Junio C HamanoJun 27, 2025
  9. Ayush ChandekarJun 28, 2025
  10. Phillip WoodJun 28, 2025
  11. Ayush ChandekarJun 28, 2025
  12. Phillip WoodJun 30, 2025
  13. Ayush ChandekarJun 30, 2025
  14. Phillip WoodJun 28, 2025
  15. Junio C HamanoJun 30, 2025
  16. Ayush ChandekarJun 28, 2025
  17. Christian CouderJun 27, 2025
  18. commit: avoid scanning trailing comments when 'core.commentChar' is "auto"Ayush Chandekar, Jun 30, 2025
  19. Phillip WoodJul 1, 2025
  20. Ayush ChandekarJul 1, 2025
  21. Phillip WoodJul 1, 2025
  22. Ayush ChandekarJul 2, 2025
  23. Phillip WoodJul 4, 2025
  24. Ayush ChandekarJul 8, 2025
  25. Phillip WoodJul 9, 2025
  26. 0/2 commit: improve behaviour of core.commentChar=auto for comments in commit messagesAyush Chandekar, Jul 15, 2025
  27. 1/2 commit: avoid scanning trailing comments when 'core.commentChar' is "auto"Ayush Chandekar, Jul 15, 2025
  28. 2/2 config: set comment_line_str to "#" when core.commentChar=autoAyush Chandekar, Jul 15, 2025
  29. Junio C HamanoJul 15, 2025
  30. Ayush ChandekarJul 15, 2025
  31. Junio C HamanoJul 15, 2025
  32. Ayush ChandekarJul 16, 2025
  33. Junio C HamanoJul 16, 2025
  34. Phillip WoodJul 16, 2025
  35. Junio C HamanoJul 16, 2025
  36. 0/2 commit: improve behaviour of core.commentChar=auto for comments in commit messagesAyush Chandekar, Jul 16, 2025
  37. 1/2 commit: avoid scanning trailing comments when 'core.commentChar' is "auto"Ayush Chandekar, Jul 16, 2025
  38. 2/2 config: set comment_line_str to "#" when core.commentChar=autoAyush Chandekar, Jul 16, 2025
  39. Junio C HamanoJul 16, 2025
  40. Phillip WoodJul 16, 2025
  41. Junio C HamanoJul 16, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.