git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC PATCH v1 0/4] Fix `cargo package` for libgit-sys

From
Josh Steadmon <steadmon@google.com>
Date
Mar 18, 2025, 23:24 UTC
Message-ID
<cover.1742339107.git.josh@steadmon.net>

Fix a variety of issues with `cargo package` for the libgit-sys crate. Most of these are straightforward, but patch #2 carries an unfortunate side-effect that building the libgit-sys crate requires cleaning the Git worktree in the process. Please see the patch description there for discussion of possible alternatives, and please suggest any other ideas you might have for that issue.

`cargo package` for the libgit-rs crate is still broken for now, because it will require publishing the the libgit-sys crate first.

Josh Steadmon (4):
  libgitpub: move to separate contrib/ directory
  libgit-sys: add symlink to git repo root and clean after build
  libgit-sys: parallelize build with Cargo's jobserver
  libgit-sys: exclude unnecessary directories in git-src
 Makefile                                      | 36 ++++++++++++++-----
 contrib/libgit-sys/Cargo.toml                 | 12 +++++++
 contrib/libgit-sys/build.rs                   | 34 ++++++++++++++++--
 contrib/libgit-sys/git-src                    |  1 +
 .../public_symbol_export.c                    |  2 +-
 .../public_symbol_export.h                    |  0
 6 files changed, 72 insertions(+), 13 deletions(-)
 create mode 120000 contrib/libgit-sys/git-src
 rename contrib/{libgit-sys => libgitpub}/public_symbol_export.c (96%)
 rename contrib/{libgit-sys => libgitpub}/public_symbol_export.h (100%)
base-commit: 683c54c999c301c2cd6f715c411407c413b1d84e
-- 
2.49.0.rc1.451.g8f38331e32-goog
Next: Josh Steadmon
Message 1 of 21 in “Fix `cargo package` for libgit-sys”
  1. 0/4 Fix `cargo package` for libgit-sysJosh Steadmon, Mar 18, 2025
  2. 1/4 libgitpub: move to separate contrib/ directoryJosh Steadmon, Mar 18, 2025
  3. 2/4 libgit-sys: add symlink to git repo root and clean after buildJosh Steadmon, Mar 18, 2025
  4. Josh SteadmonMar 19, 2025
  5. Phillip WoodMar 20, 2025
  6. Josh SteadmonMar 21, 2025
  7. 3/4 libgit-sys: parallelize build with Cargo's jobserverJosh Steadmon, Mar 18, 2025
  8. 4/4 libgit-sys: exclude unnecessary directories in git-srcJosh Steadmon, Mar 18, 2025
  9. 0/5 Fix `cargo package` for libgit-sysJosh Steadmon, Mar 21, 2025
  10. 1/5 libgitpub: move to separate contrib/ directoryJosh Steadmon, Mar 21, 2025
  11. 2/5 libgit-sys: add symlink to git repo root and build out of treeJosh Steadmon, Mar 21, 2025
  12. Eric SunshineMar 23, 2025
  13. Junio C HamanoMar 24, 2025
  14. Josh SteadmonMar 25, 2025
  15. Junio C HamanoMar 25, 2025
  16. Josh SteadmonMar 27, 2025
  17. Junio C HamanoMar 29, 2025
  18. Johannes SchindelinMar 31, 2025
  19. 3/5 libgit-sys: parallelize build with Cargo's jobserverJosh Steadmon, Mar 21, 2025
  20. 4/5 libgit-sys: exclude unnecessary directories in git-srcJosh Steadmon, Mar 21, 2025
  21. 5/5 libgit-{sys,rs}: add license and description fieldsJosh Steadmon, Mar 21, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.