git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/3] Add additional trace2 regions for fetch and push

From
Josh Steadmon <steadmon@google.com>
Date
Aug 22, 2024, 21:57 UTC
Message-ID
<cover.1724363615.git.steadmon@google.com>
In-Reply-To
<cover.1723747832.git.steadmon@google.com>

Last year at $DAYJOB we were having issues with slow fetches/pulls/pushes. We added some additional trace2 regions which helped us narrow down the issue to some server-side negotiation problems. We've been carrying these patches downstream ever since, but they might be useful to others as well.

Changes in V2:
* Added a new patch to implement trace2_printf() for event targets.
* Move some fetch trace regions deeper in the call stack to simplify
  control flow.
* Move some push trace regions deeper in the call stack to target the
  actual slow functions, and to not tie tracing to whether or not
  sideband communication is used.
Calvin Wan (1):
  send-pack: add new tracing regions for push
Josh Steadmon (2):
  trace2: implement trace2_printf() for event target
  fetch: add top-level trace2 regions
 Documentation/technical/api-trace2.txt | 17 +++++++++++++++--
 builtin/fetch.c                        | 16 +++++++++++++++-
 bundle-uri.c                           |  4 ++++
 send-pack.c                            | 16 +++++++++++++---
 trace2/tr2_tgt_event.c                 | 22 ++++++++++++++++++++--
 5 files changed, 67 insertions(+), 8 deletions(-)
base-commit: 25673b1c476756ec0587fb0596ab3c22b96dc52a
-- 
2.46.0.295.g3b9ea8a38a-goog
Previous: Junio C HamanoNext: Josh Steadmon
Message 9 of 13 in “Add additional trace2 regions for fetch and push”
  1. 0/2 Add additional trace2 regions for fetch and pushJosh Steadmon, Aug 15, 2024
  2. 1/2 fetch: add top-level trace2 regionsJosh Steadmon, Aug 15, 2024
  3. Junio C HamanoAug 15, 2024
  4. Josh SteadmonAug 19, 2024
  5. 2/2 send-pack: add new tracing regions for pushJosh Steadmon, Aug 15, 2024
  6. Junio C HamanoAug 15, 2024
  7. Josh SteadmonAug 22, 2024
  8. Junio C HamanoAug 22, 2024
  9. 0/3 Add additional trace2 regions for fetch and pushJosh Steadmon, Aug 22, 2024
  10. 1/3 trace2: implement trace2_printf() for event targetJosh Steadmon, Aug 22, 2024
  11. 2/3 fetch: add top-level trace2 regionsJosh Steadmon, Aug 22, 2024
  12. 3/3 send-pack: add new tracing regions for pushJosh Steadmon, Aug 22, 2024
  13. Junio C HamanoAug 22, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.