git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v5 0/1] range-diff: treat notes like `log`

From
Kristoffer Haugsbakk <code@khaugsbakk.name>
Date
Sep 19, 2023, 20:26 UTC
Message-ID
<cover.1695154855.git.code@khaugsbakk.name>
In-Reply-To
<cover.1695144790.git.code@khaugsbakk.name>
Hi
See the previous cover letter for context.
§ Changes since version 4

• Remove “Root cause” section from commit message • Doc change according to feedback

Kristoffer Haugsbakk (1):
  range-diff: treat notes like `log`
 Documentation/pretty-options.txt |  4 ++++
 range-diff.c                     |  2 +-
 revision.c                       |  7 +++++++
 revision.h                       |  1 +
 t/t3206-range-diff.sh            | 28 ++++++++++++++++++++++++++++
 5 files changed, 41 insertions(+), 1 deletion(-)
Range-diff against v4:
1:  244e102cc46 ! 1:  6e114271a2e range-diff: treat notes like `log`
    @@ Commit message
         Remedy this by introducing `--show-notes-by-default` that `range-diff` can
         use to tell the `log` subprocess what to do.
    -    § Root cause
    -
    -    8cf51561d1e (range-diff: fix a crash in parsing git-log output,
    -    2020-04-15) added `--notes` in order to deal with a side-effect of
    -    `--pretty=medium`:
    -
    -    > To fix this explicitly set the output format of the internally executed
    -    > `git log` with `--pretty=medium`. Because that cancels `--notes`, add
    -    > explicitly `--notes` at the end.
    -
         § Authors
         • Fix by Johannes
    @@ Commit message
         Signed-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name>
      ## Documentation/pretty-options.txt ##
    -@@ Documentation/pretty-options.txt: message by 4 spaces (i.e.  'medium', which is the default, 'full',
    - and 'fuller').
    +@@ Documentation/pretty-options.txt: being displayed. Examples: "--notes=foo" will show only notes from
    + 	"--notes --notes=foo --no-notes --notes=bar" will only show notes
    + 	from "refs/notes/bar".
    - ifndef::git-rev-list[]
     +--show-notes-by-default::
    -+	Show the default notes (see `--notes`) unless subsequent arguments
    -+	are used to display specific notes.
    ++	Show the default notes unless options for displaying specific
    ++	notes are given.
     +
    - --notes[=<ref>]::
    - 	Show the notes (see linkgit:git-notes[1]) that annotate the
    - 	commit, when showing the commit log message.  This is the default
    + --show-notes[=<ref>]::
    + --[no-]standard-notes::
    + 	These options are deprecated. Use the above --notes/--no-notes
      ## range-diff.c ##
     @@ range-diff.c: static int read_patches(const char *range, struct string_list *list,
--
2.42.0
Previous: Junio C HamanoNext: Kristoffer Haugsbakk
Message 39 of 41 in “range-diff: treat notes like `log`”
  1. 0/3 range-diff: treat notes like `log`Kristoffer Haugsbakk, May 30, 2023
  2. 1/3 range-diff: treat notes like `log`Kristoffer Haugsbakk, May 30, 2023
  3. Jeff KingJun 1, 2023
  4. Kristoffer HaugsbakkJun 2, 2023
  5. 2/3 doc: pretty-options: remove documentation for deprecated optionsKristoffer Haugsbakk, May 30, 2023
  6. 3/3 revision: comment `--no-standard-notes` as deprecatedKristoffer Haugsbakk, May 30, 2023
  7. 0/3 range-diff: treat notes like `log`Kristoffer Haugsbakk, Jun 11, 2023
  8. 2/3 doc: pretty-options: remove documentation for deprecated optionsKristoffer Haugsbakk, Jun 11, 2023
  9. 3/3 revision: comment `--no-standard-notes` as deprecatedKristoffer Haugsbakk, Jun 11, 2023
  10. Junio C HamanoJun 12, 2023
  11. Kristoffer HaugsbakkJun 13, 2023
  12. 1/3 range-diff: treat notes like `log`Kristoffer Haugsbakk, Jun 11, 2023
  13. Junio C HamanoJun 12, 2023
  14. Kristoffer HaugsbakkJun 13, 2023
  15. 0/3 range-diff: treat notes like `log`Kristoffer Haugsbakk, Sep 1, 2023
  16. 1/3 range-diff: treat notes like `log`Kristoffer Haugsbakk, Sep 1, 2023
  17. Johannes SchindelinSep 3, 2023
  18. Kristoffer HaugsbakkSep 4, 2023
  19. Johannes SchindelinSep 5, 2023
  20. Junio C HamanoSep 5, 2023
  21. 2/3 doc: pretty-options: remove documentation for deprecated optionsKristoffer Haugsbakk, Sep 1, 2023
  22. 3/3 revision: comment `--no-standard-notes` as deprecatedKristoffer Haugsbakk, Sep 1, 2023
  23. 0/1 range-diff: treat notes like `log`Kristoffer Haugsbakk, Sep 10, 2023
  24. 1/1 range-diff: treat notes like `log`Kristoffer Haugsbakk, Sep 10, 2023
  25. Junio C HamanoSep 11, 2023
  26. Johannes SchindelinSep 14, 2023
  27. Junio C HamanoSep 14, 2023
  28. Kristoffer HaugsbakkSep 14, 2023
  29. Junio C HamanoSep 19, 2023
  30. Kristoffer HaugsbakkSep 19, 2023
  31. Johannes SchindelinSep 11, 2023
  32. 0/1 range-diff: treat notes like `log`Kristoffer Haugsbakk, Sep 19, 2023
  33. 1/1 range-diff: treat notes like `log`Kristoffer Haugsbakk, Sep 19, 2023
  34. Junio C HamanoSep 19, 2023
  35. Kristoffer HaugsbakkSep 19, 2023
  36. Junio C HamanoSep 19, 2023
  37. Kristoffer HaugsbakkSep 19, 2023
  38. Junio C HamanoSep 19, 2023
  39. 0/1 range-diff: treat notes like `log`Kristoffer Haugsbakk, Sep 19, 2023
  40. 1/1 range-diff: treat notes like `log`Kristoffer Haugsbakk, Sep 19, 2023
  41. Johannes SchindelinSep 21, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.