git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/3] repack: handle --keep-pack, --max-pack-size for geometric repacks

From
Taylor Blau <me@ttaylorr.com>
Date
May 20, 2022, 19:01 UTC
Message-ID
<cover.1653073280.git.me@ttaylorr.com>

This series fixes two issues that Victoria and I noticed while working on an unrelated issue yesterday.

  - The first patch comes from Victoria's earlier submission[1], and addresses
    an issue where packs specified as kept via the `--keep-pack` option could
    potentially be removed (without rewriting their objects) during a
    `--geometric` repack.
    The first patch is Victoria's alone, with some minor fixups applied from my
    review in [2]. It's included in this series since it's related, and avoids
    any conflicts when merging.
  - The latter two patches are mine, and address an issue where specifying a
    `--max-pack-size` value during a `--geometric` repack could result in object
    loss because of a false positive in our "did we write a pack with this
    name?" check (which can occur when the list of packs we wrote isn't sorted).
    The first of these two patches demonstrates the issue (done in a separate
    patch, since the scenario is quite involved), and the second patch fixes the
    bug.
Thanks in advance for your review.

[1]: https://lore.kernel.org/git/pull.1235.git.1653064572170.gitgitgadget@gmail.com/ [2]: https://lore.kernel.org/git/YofJLv8+x5J7yPmf@nand.local/

Taylor Blau (2):
  t7703: demonstrate object corruption with pack.packSizeLimit
  builtin/repack.c: ensure that `names` is sorted
Victoria Dye (1):
  repack: respect --keep-pack with geometric repack
 builtin/repack.c            | 49 ++++++++++++++++++------
 t/t7703-repack-geometric.sh | 75 +++++++++++++++++++++++++++++++++++++
 2 files changed, 112 insertions(+), 12 deletions(-)
-- 
2.36.1.94.gb0d54bedca
Next: Taylor Blau
Message 1 of 10 in “repack: handle --keep-pack, --max-pack-size for geometric repacks”
  1. 0/3 repack: handle --keep-pack, --max-pack-size for geometric repacksTaylor Blau, May 20, 2022
  2. 1/3 repack: respect --keep-pack with geometric repackTaylor Blau, May 20, 2022
  3. 2/3 t7703: demonstrate object corruption with pack.packSizeLimitTaylor Blau, May 20, 2022
  4. Victoria DyeMay 20, 2022
  5. Taylor BlauMay 20, 2022
  6. Junio C HamanoMay 20, 2022
  7. 3/3 builtin/repack.c: ensure that `names` is sortedTaylor Blau, May 20, 2022
  8. Victoria DyeMay 20, 2022
  9. Derrick StoleeMay 20, 2022
  10. Junio C HamanoMay 20, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.