git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/1] commit-graph: drop top-level --[no-]progress

From
Taylor Blau <me@ttaylorr.com>
Date
Sep 18, 2021, 16:02 UTC
Message-ID
<cover.1631980949.git.me@ttaylorr.com>

This patch provides one way to fix an issue that SZEDER described in [1]. The issue is that `git commit-graph` began accepting `--[no-]progress` as a top-level argument as an unintentional side-effect of 84e4484f12 (commit-graph: use parse_options_concat(), 2021-08-23).

Some discussion beginning at [2] indicates a couple of reasons why this is undesirable, and they are summarized in the patch below.

But most importantly, if we do want to get rid of the top-level `--[no-]progress`, then we should act quickly to do it before 84e4484f12 (which currently isn't tagged) is released.

An open question is whether the same should be done for the multi-pack-index command, whose top-level support for `--[no-]progress` was released in v2.32.0 with 60ca94769c (builtin/multi-pack-index.c: split sub-commands, 2021-03-30).

[1]: https://lore.kernel.org/git/20210917211337.GC2118053@szeder.dev/ [2]: https://lore.kernel.org/git/YUUQzswYL5x74Tps@coredump.intra.peff.net/

Taylor Blau (1):
  builtin/commit-graph.c: don't accept common --[no-]progress
 builtin/commit-graph.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
-- 
2.33.0.96.g73915697e6
Next: Taylor Blau
Message 1 of 10 in “commit-graph: drop top-level --[no-]progress”
  1. 0/1 commit-graph: drop top-level --[no-]progressTaylor Blau, Sep 18, 2021
  2. 1/1 builtin/commit-graph.c: don't accept common --[no-]progressTaylor Blau, Sep 18, 2021
  3. Derrick StoleeSep 20, 2021
  4. Taylor BlauSep 20, 2021
  5. Junio C HamanoSep 20, 2021
  6. Taylor BlauSep 20, 2021
  7. Ævar Arnfjörð BjarmasonSep 21, 2021
  8. Taylor BlauSep 21, 2021
  9. Junio C HamanoSep 22, 2021
  10. Jeff KingSep 21, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.