git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/3] Reduce number of processes spawned by git-mergetool

From
Johannes Sixt <j6t@kdbg.org>
Date
Jun 10, 2019, 08:58 UTC
Message-ID
<cover.1560152205.git.j6t@kdbg.org>

git-mergetool spawns an enormous amount of processes. For this reason, the test script, t7610, is exceptionally slow, in particular, on Windows. Most of the processes are invocations of git, but there are also some that can be replaced with shell builtins.

I've measured the number of processes with
  ps; ./t7610-mergetool.sh >/dev/null; ps
on a quiet system and the number of non-git commands invoked with
  strace -e execve -f -o /tmp/git.strace ./t7610-mergetool.sh
  grep 'execve(' /tmp/git.strace | grep -v 'execve(".home' | wc -l

baseline: 15628 pts/1 00:00:00 ps 29413 pts/1 00:00:00 ps

=> 13785 processes => 3082 non-git commands

t7610-mergetool: do not place pipelines headed by `yes` in subshells 12620 pts/1 00:00:00 ps 26348 pts/1 00:00:00 ps

=> 13728 processes => 3082 non-git commands

mergetool: dissect strings with shell variable magic instead of `expr`
 8766 pts/1    00:00:00 ps
21913 pts/1    00:00:00 ps

=> 13147 processes => 2521 non-git commands

mergetool: use shell variable magic instead of `awk`
 2081 pts/1    00:00:00 ps
14393 pts/1    00:00:00 ps

=> 12312 processes => 2007 non-git commands

The reduction of processes is not as dramatic as I hoped, but still more than 10%.

Johannes Sixt (3):
  t7610-mergetool: do not place pipelines headed by `yes` in subshells
  mergetool: dissect strings with shell variable magic instead of `expr`
  mergetool: use shell variable magic instead of `awk`
 git-mergetool.sh     |  45 ++++++++----
 t/t7610-mergetool.sh | 170 +++++++++++++++++++++----------------------
 2 files changed, 116 insertions(+), 99 deletions(-)
-- 
2.21.0.285.gc38d92e052
Next: Johannes Sixt
Message 1 of 18 in “Reduce number of processes spawned by git-mergetool”
  1. 0/3 Reduce number of processes spawned by git-mergetoolJohannes Sixt, Jun 10, 2019
  2. 1/3 t7610-mergetool: do not place pipelines headed by `yes` in subshellsJohannes Sixt, Jun 10, 2019
  3. SZEDER GáborJun 10, 2019
  4. Junio C HamanoJun 10, 2019
  5. SZEDER GáborJun 10, 2019
  6. Johannes SchindelinJun 10, 2019
  7. SZEDER GáborJun 10, 2019
  8. 2/3 mergetool: dissect strings with shell variable magic instead of `expr`Johannes Sixt, Jun 10, 2019
  9. Junio C HamanoJun 10, 2019
  10. Johannes SixtJun 10, 2019
  11. 3/3 mergetool: use shell variable magic instead of `awk`Johannes Sixt, Jun 10, 2019
  12. Junio C HamanoJun 10, 2019
  13. Johannes SixtJun 10, 2019
  14. 0/4 Reduce number of processes spawned by git-mergetoolJohannes Sixt, Jun 12, 2019
  15. 3/4 mergetool: dissect strings with shell variable magic instead of `expr`Johannes Sixt, Jun 12, 2019
  16. 4/4 mergetool: use shell variable magic instead of `awk`Johannes Sixt, Jun 12, 2019
  17. 1/4 t7610-mergetool: do not place pipelines headed by `yes` in subshellsJohannes Sixt, Jun 12, 2019
  18. 2/4 t7610-mergetool: use test_cmp instead of test $(cat file) = $txtJohannes Sixt, Jun 12, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.