git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/2] Lazy fetch bug fix (and feature that reveals it)

From
JTJonathan Tan <jonathantanmy@google.com>
Date
Oct 3, 2018, 23:04 UTC
Message-ID
<cover.1538607476.git.jonathantanmy@google.com>
In-Reply-To
<20180924154516.48704-1-jonathantanmy@google.com>
> This seems to break 5520 and 5616 when merged to 'pu'.  
> 
> It seems that merging master to md/filter-trees and then applying
> this is sufficient to break 5616.

I verified that 5616 is broken on [master + md/filter-trees + my patch], and after investigation, found a bug in the lazy fetch implementation. Patch 1 contains a fix, and more information about that bug.

Patch 2 is the original patch, updated with the commit message I suggested [1] in reply to Junio's comment.

I bundled these patches together because patch 2 (in combination with certain other commits) reveals the bug that patch 1 fixes, and to make it easier for others to verify that these patches together pass all tests when rebased on [master + md/filter-trees] or 'pu' (at least, as of the time of writing).

[1] https://public-inbox.org/git/20180927183718.89804-1-jonathantanmy@google.com/
Jonathan Tan (2):
  fetch-pack: avoid object flags if no_dependents
  fetch-pack: exclude blobs when lazy-fetching trees
 fetch-pack.c             | 115 +++++++++++++++++++++++++--------------
 fetch-pack.h             |   7 +++
 t/t0410-partial-clone.sh |  41 ++++++++++++++
 3 files changed, 121 insertions(+), 42 deletions(-)
-- 
2.19.0.605.g01d371f741-goog
Previous: Junio C HamanoNext: Jonathan Tan
Message 5 of 7 in “fetch-pack: approximate no_dependents with filter”
  1. fetch-pack: approximate no_dependents with filterJonathan Tan, Sep 24, 2018
  2. Junio C HamanoSep 25, 2018
  3. Jonathan TanSep 27, 2018
  4. Junio C HamanoSep 29, 2018
  5. 0/2 Lazy fetch bug fix (and feature that reveals it)Jonathan Tan, Oct 3, 2018
  6. 1/2 fetch-pack: avoid object flags if no_dependentsJonathan Tan, Oct 3, 2018
  7. 2/2 fetch-pack: exclude blobs when lazy-fetching treesJonathan Tan, Oct 3, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.