git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/3] Re: t7006: add tests for how git config paginates

From
MÅMartin Ågren <martin.agren@gmail.com>
Date
Feb 21, 2018, 18:51 UTC
Message-ID
<cover.1519238410.git.martin.agren@gmail.com>
In-Reply-To
<450ff45707b58d6796d55cd594b50686e5d62fc2.1518365675.git.martin.agren@gmail.com>

This is v2 of my series to teach `git config` to only respect `pager.config` when listing configuration, then changing the default to "on". Thanks to Duy and Junio for feedback on the first version.

Based on Duy's feeback, I've changed the approach to more carefully divide the various getters into "may produce multiple lines, so let's page" vs "may not, so don't".

Junio hesitated whether we should add tests using `test_expect_success`, then flip the test-definition, or whether we should start with a "failure" that we then flip to "success". I have not done anything about that, except to try and motivate the choice better in the commit message of the second patch.

Martin
Martin Ågren (3):
  t7006: add tests for how git config paginates
  config: respect `pager.config` in list/get-mode only
  config: change default of `pager.config` to "on"
 Documentation/git-config.txt |  6 ++++++
 t/t7006-pager.sh             | 49 +++++++++++++++++++++++++++++++++++++-------
 builtin/config.c             | 10 +++++++++
 git.c                        |  2 +-
 4 files changed, 59 insertions(+), 8 deletions(-)
-- 
2.16.2.246.ga4ee44448f
Previous: Martin ÅgrenNext: Martin Ågren
Message 8 of 12 in “t7006: add tests for how git config paginates”
  1. 1/3 t7006: add tests for how git config paginatesMartin Ågren, Feb 11, 2018
  2. 2/3 config: respect `pager.config` in list/get-mode onlyMartin Ågren, Feb 11, 2018
  3. Duy NguyenFeb 13, 2018
  4. Martin ÅgrenFeb 13, 2018
  5. 3/3 config: change default of `pager.config` to "on"Martin Ågren, Feb 11, 2018
  6. Junio C HamanoFeb 12, 2018
  7. Martin ÅgrenFeb 12, 2018
  8. 0/3 Re: t7006: add tests for how git config paginatesMartin Ågren, Feb 21, 2018
  9. 1/3 t7006: add tests for how git config paginatesMartin Ågren, Feb 21, 2018
  10. 2/3 config: respect `pager.config` in list/get-mode onlyMartin Ågren, Feb 21, 2018
  11. 3/3 config: change default of `pager.config` to "on"Martin Ågren, Feb 21, 2018
  12. Junio C HamanoFeb 21, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.