git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[WIP 0/2] Modifying pack-objects to support --blob-size-limit

From
JTJonathan Tan <jonathantanmy@google.com>
Date
Jun 2, 2017, 00:14 UTC
Message-ID
<cover.1496361873.git.jonathantanmy@google.com>

I took a look at modifying builtin/pack-objects.c to support excluding oversized blobs and reporting the exclusions that it has performed. Here's a work in progress - it might be of aid to others who are working on a similar feature and/or are modifying pack-objects for something else.

The way I used to obtain a blob's size seems inefficient and redundant with check_object() - if you have a suggestion to improve this, I'm interested.

This is similar to [1] except that this reports blobs and their sizes (after the packfile is printed), and is slightly more comprehensive in that the read_object_list_from_stdin() codepath is also covered in addition to the get_object_list() codepath. (Although, to be clear, upload-pack always passes "--revs" and thus only needs the get_object_list() codepath).

[1] https://public-inbox.org/git/1488994685-37403-3-git-send-email-jeffhost@microsoft.com/
Jonathan Tan (2):
  pack-objects: rename want_.* to ignore_.*
  pack-objects: support --blob-size-limit
 Documentation/git-pack-objects.txt |  19 ++++-
 builtin/pack-objects.c             | 163 ++++++++++++++++++++++++++++++-------
 t/t5300-pack-object.sh             |  71 ++++++++++++++++
 3 files changed, 223 insertions(+), 30 deletions(-)
-- 
2.13.0.506.g27d5fe0cd-goog
Next: Jonathan Tan
Message 1 of 17 in “[WIP 0/2] Modifying pack-objects to support --blob-size-limit”
  1. Jonathan TanJun 2, 2017
  2. 1/2 pack-objects: rename want_.* to ignore_.*Jonathan Tan, Jun 2, 2017
  3. Junio C HamanoJun 2, 2017
  4. 2/2 pack-objects: support --blob-size-limitJonathan Tan, Jun 2, 2017
  5. Junio C HamanoJun 2, 2017
  6. 0/2 Modifying pack objects to support --blob-max-bytesJonathan Tan, Jun 2, 2017
  7. 1/2 pack-objects: rename want_.* to ignore_.*Jonathan Tan, Jun 2, 2017
  8. 2/2 pack-objects: support --blob-max-bytesJonathan Tan, Jun 2, 2017
  9. Jeff KingJun 2, 2017
  10. Jonathan NiederJun 2, 2017
  11. Jeff KingJun 7, 2017
  12. Junio C HamanoJun 3, 2017
  13. Jeff HostetlerJun 15, 2017
  14. Jonathan TanJun 15, 2017
  15. Jeff KingJun 2, 2017
  16. Jonathan TanJun 5, 2017
  17. Jeff KingJun 7, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.