git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/1] difftool: fix a use-after-free bug

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Apr 13, 2017, 19:21 UTC
Message-ID
<cover.1492111288.git.johannes.schindelin@gmx.de>

It has been reported previously that the base_dir recorded at the beginning of run_dir_diff() may go stale due to the buffer to which it points potentially being realloc()ed.

This bug has been fixed in Git for Windows 2.12.2(2) already. It took me this long (!!!) to come up with a reliable test case... But now that I have it, it can be easily verified.

Johannes Schindelin (1):
  difftool: fix use-after-free
 builtin/difftool.c  |  7 +++++--
 t/t7800-difftool.sh | 19 +++++++++++++++++++
 2 files changed, 24 insertions(+), 2 deletions(-)
base-commit: cf11a67975b057a144618badf16dc4e3d25b9407
Published-As: https://github.com/dscho/git/releases/tag/fix-difftool-d-crash-v1
Fetch-It-Via: git fetch https://github.com/dscho/git fix-difftool-d-crash-v1
-- 
2.12.2.windows.2.1.g7df5db8d31e
Next: Johannes Schindelin
Message 1 of 3 in “difftool: fix a use-after-free bug”
  1. 0/1 difftool: fix a use-after-free bugJohannes Schindelin, Apr 13, 2017
  2. 1/1 difftool: fix use-after-freeJohannes Schindelin, Apr 13, 2017
  3. Jonathan NiederApr 13, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.