git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/2] Fix segmentation fault with cherry-pick

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Nov 25, 2016, 16:36 UTC
Message-ID
<cover.1480091758.git.johannes.schindelin@gmx.de>

The culprit is actually not cherry-pick, but a special code path that expects refresh_cache_entry() not to return NULL. And the fix is to teach it to handle NULL there.

This bug was brought to my attention by Markus Klein via https://github.com/git-for-windows/git/issues/952.

Johannes Schindelin (2):
  cherry-pick: demonstrate a segmentation fault
  Avoid a segmentation fault with renaming merges
 merge-recursive.c             |  2 ++
 t/t3501-revert-cherry-pick.sh | 12 ++++++++++++
 2 files changed, 14 insertions(+)
base-commit: e2b2d6a172b76d44cb7b1ddb12ea5bfac9613a44
Published-As: https://github.com/dscho/git/releases/tag/cherry-pick-segfault-v1
Fetch-It-Via: git fetch https://github.com/dscho/git cherry-pick-segfault-v1
-- 
2.11.0.rc3.windows.1
Next: Johannes Schindelin
Message 1 of 11 in “Fix segmentation fault with cherry-pick”
  1. 0/2 Fix segmentation fault with cherry-pickJohannes Schindelin, Nov 25, 2016
  2. 1/2 cherry-pick: demonstrate a segmentation faultJohannes Schindelin, Nov 25, 2016
  3. Johannes SchindelinNov 26, 2016
  4. 2/2 Avoid a segmentation fault with renaming mergesJohannes Schindelin, Nov 25, 2016
  5. Johannes SchindelinNov 25, 2016
  6. 0/2 Fix segmentation fault with cherry-pickJohannes Schindelin, Nov 26, 2016
  7. 1/2 cherry-pick: demonstrate a segmentation faultJohannes Schindelin, Nov 26, 2016
  8. 2/2 Avoid a segmentation fault with renaming mergesJohannes Schindelin, Nov 26, 2016
  9. Johannes SchindelinNov 26, 2016
  10. Junio C HamanoNov 28, 2016
  11. Junio C HamanoNov 28, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.