git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/2] handle empty spec-compliant remote repos correctly

From
JTJonathan Tan <jonathantanmy@google.com>
Date
Sep 2, 2016, 17:15 UTC
Message-ID
<cover.1472836026.git.jonathantanmy@google.com>

This issue was noticed when trying to clone an empty repository served by a server that uses the JGit library.

Reference Discovery in Documentation/technical/pack-protocol.txt dictates that servers should send a zero ID when there are no refs in the queried repository, and implementations like JGit do, but the C client does not handle them correctly (treating them as an actual ref and subsequently returning incorrect responses or errors).

These patches fix those while maintaining backwards compatibility with existing implementations that do not send the zero ID in such a case.

Jonathan Tan (2):
  tests: move test_lazy_prereq JGIT to test-lib.sh
  connect: know that zero-ID is not a ref
 connect.c               |  7 +++++++
 t/t5310-pack-bitmaps.sh |  4 ----
 t/t5512-ls-remote.sh    | 22 ++++++++++++++++++++++
 t/test-lib.sh           |  4 ++++
 4 files changed, 33 insertions(+), 4 deletions(-)
-- 
2.8.0.rc3.226.g39d4020
Next: Jonathan Tan
Message 1 of 45 in “handle empty spec-compliant remote repos correctly”
  1. 0/2 handle empty spec-compliant remote repos correctlyJonathan Tan, Sep 2, 2016
  2. 2/2 connect: know that zero-ID is not a refJonathan Tan, Sep 2, 2016
  3. Jonathan NiederSep 2, 2016
  4. Shawn PearceSep 2, 2016
  5. Stefan BellerSep 2, 2016
  6. Shawn PearceSep 2, 2016
  7. Jeff KingSep 2, 2016
  8. Jonathan TanSep 2, 2016
  9. Jeff KingSep 2, 2016
  10. Shawn PearceSep 3, 2016
  11. Jeff KingSep 3, 2016
  12. 1/2 tests: move test_lazy_prereq JGIT to test-lib.shJonathan Tan, Sep 2, 2016
  13. 0/2 handle empty spec-compliant remote repos correctlyJonathan Tan, Sep 2, 2016
  14. 1/2 tests: move test_lazy_prereq JGIT to test-lib.shJonathan Tan, Sep 2, 2016
  15. Junio C HamanoSep 7, 2016
  16. 2/2 connect: advertized capability is not a refJonathan Tan, Sep 2, 2016
  17. Jonathan NiederSep 2, 2016
  18. Jeff KingSep 2, 2016
  19. Stefan BellerSep 2, 2016
  20. Jonathan NiederSep 3, 2016
  21. Jonathan NiederSep 2, 2016
  22. Jeff KingSep 3, 2016
  23. Junio C HamanoSep 7, 2016
  24. Junio C HamanoSep 7, 2016
  25. Jonathan NiederSep 7, 2016
  26. Junio C HamanoSep 7, 2016
  27. 0/2 handle empty spec-compliant remote repos correctlyJonathan Tan, Sep 7, 2016
  28. 1/2 tests: move test_lazy_prereq JGIT to test-lib.shJonathan Tan, Sep 7, 2016
  29. 2/2 connect: advertized capability is not a refJonathan Tan, Sep 7, 2016
  30. Jonathan NiederSep 8, 2016
  31. connect: tighten check for unexpected early hang up (Re: [PATCH v3 2/2] connect: advertized capability is not a ref)Jonathan Nieder, Sep 8, 2016
  32. Jonathan NiederSep 8, 2016
  33. Jonathan NiederSep 8, 2016
  34. Junio C HamanoSep 8, 2016
  35. Stefan BellerSep 8, 2016
  36. Junio C HamanoSep 8, 2016
  37. 0/3 handle empty spec-compliant remote repos correctlyJonathan Tan, Sep 9, 2016
  38. 1/3 tests: move test_lazy_prereq JGIT to test-lib.shJonathan Tan, Sep 9, 2016
  39. Torsten BögershausenSep 10, 2016
  40. Jeff KingSep 10, 2016
  41. 3/3 connect: advertized capability is not a refJonathan Tan, Sep 9, 2016
  42. Jonathan NiederSep 9, 2016
  43. Junio C HamanoSep 9, 2016
  44. Junio C HamanoSep 9, 2016
  45. 2/3 connect: tighten check for unexpected early hang upJonathan Tan, Sep 9, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.