git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 0/4] Fix how for-each-ref handles broken loose references

From
Michael Haggerty <mhagger@alum.mit.edu>
Date
Jun 3, 2015, 13:51 UTC
Message-ID
<cover.1433339279.git.mhagger@alum.mit.edu>

This reroll addresses all of the comments about v1 [1] and v2 [2]. Thanks to Stefan, Junio, and Peff for their comments about v2.

Changes since v2:
* Simplify logic flow in read_loose_refs().
* Remove unnecessary call to hashclr() in read_loose_refs().
* Improve a comment and commit message.

This patch series is also available from my GitHub account [3] as branch for-each-ref-errors.

[1] http://thread.gmane.org/gmane.comp.version-control.git/270429 [2] http://thread.gmane.org/gmane.comp.version-control.git/270556 [3] https://github.com/mhagger/git

Michael Haggerty (4):
  t6301: new tests of for-each-ref error handling
  for-each-ref: report broken references correctly
  read_loose_refs(): simplify function logic
  read_loose_refs(): treat NULL_SHA1 loose references as broken
 builtin/for-each-ref.c         |  5 ++++
 refs.c                         | 29 ++++++++++++++++------
 t/t6301-for-each-ref-errors.sh | 56 ++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 83 insertions(+), 7 deletions(-)
 create mode 100755 t/t6301-for-each-ref-errors.sh
-- 
2.1.4
Next: Michael Haggerty
Message 1 of 11 in “Fix how for-each-ref handles broken loose references”
  1. 0/4 Fix how for-each-ref handles broken loose referencesMichael Haggerty, Jun 3, 2015
  2. 1/4 t6301: new tests of for-each-ref error handlingMichael Haggerty, Jun 3, 2015
  3. 2/4 for-each-ref: report broken references correctlyMichael Haggerty, Jun 3, 2015
  4. 3/4 read_loose_refs(): simplify function logicMichael Haggerty, Jun 3, 2015
  5. 4/4 read_loose_refs(): treat NULL_SHA1 loose references as brokenMichael Haggerty, Jun 3, 2015
  6. Jeff KingJun 3, 2015
  7. Junio C HamanoJun 3, 2015
  8. Jeff KingJun 3, 2015
  9. Junio C HamanoJun 3, 2015
  10. Michael HaggertyJun 8, 2015
  11. Junio C HamanoJun 8, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.