git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/7] gitk -L

From
Thomas Rast <tr@thomasrast.ch>
Date
Oct 29, 2013, 07:20 UTC
Message-ID
<cover.1383031141.git.tr@thomasrast.ch>
In-Reply-To
<21f40508f83a9407986d29f002adf5ad366c8b88.1382287779.git.trast@inf.ethz.ch>
Thomas Rast wrote:
Show 11 quoted lines
> Jonathan Nieder wrote:
> > Support for just the sticked form is better than nothing, especially
> > if the gitk(1) manpage gains a note about it.  In the long run I guess
> > the ideal would be to add a parse-options-like library to the tcl
> > support.
> 
> Ok.  I'm generally not happy with the state of that manpage, so I took
> the chance to improve it.
> [...]
> I'll hold the gitk patches until we get this one sorted out, but then
> just do the sticked form as before.

Ok, there weren't any comments and this patch is in 'next', so here's gitk -L built on top of it.

I'm sending this as a single topic, but once agreement is reached, it has to be applied in two parts: the gitk patches (1-5) need to be subtree-rebased to match gitk.git, and then merged separately, while the documentation patches (6&7) need to be applied directly. The latter depend on the patch I'm replying to.

Changes since v1:
* 1/7 is new; while investigating the sticked/unsticked issue, I
  noticed that -G is not even supported by gitk.
* 3/7 has improved snipping logic, to get rid of an extra empty line
  before the diff
* 5/7 has a slightly different comment pointing out that this is only
  the sticked form of -L
* 6&7 are new, to resolve the sticky issue
Thomas Rast (7):
  gitk: support -G option from the command line
  gitk: refactor per-line part of getblobdiffline and its support
  gitk: split out diff part in $commitinfo
  gitk: support showing the gathered inline diffs
  gitk: recognize -L option
  Documentation: put blame/log -L in sticked form
  Documentation/gitk: document -L option
 Documentation/blame-options.txt |   8 +-
 Documentation/git-blame.txt     |   8 +-
 Documentation/git-log.txt       |   6 +-
 Documentation/gitk.txt          |  12 ++
 gitk-git/gitk                   | 467 +++++++++++++++++++++++-----------------
 5 files changed, 293 insertions(+), 208 deletions(-)
-- 
1.8.4.2.838.ga9a3e20
Previous: Thomas RastNext: Thomas Rast
Message 16 of 42 in “gitk support for git log -L”
  1. 0/4 gitk support for git log -LThomas Rast, Jun 9, 2013
  2. 1/4 gitk: refactor per-line part of getblobdiffline and its supportThomas Rast, Jun 9, 2013
  3. 2/4 gitk: split out diff part in $commitinfoThomas Rast, Jun 9, 2013
  4. 3/4 gitk: support showing the gathered inline diffsThomas Rast, Jun 9, 2013
  5. 4/4 gitk: recognize -L optionThomas Rast, Jun 9, 2013
  6. Thomas RastJul 23, 2013
  7. Thomas RastJul 29, 2013
  8. Jens LehmannJul 29, 2013
  9. Thomas RastJul 31, 2013
  10. Paul MackerrasAug 18, 2013
  11. Thomas RastAug 19, 2013
  12. Junio C HamanoAug 19, 2013
  13. Thomas RastOct 13, 2013
  14. Jonathan NiederOct 14, 2013
  15. Documentation: revamp gitk(1)Thomas Rast, Oct 20, 2013
  16. 0/7 gitk -LThomas Rast, Oct 29, 2013
  17. 1/7 gitk: support -G option from the command lineThomas Rast, Oct 29, 2013
  18. Junio C HamanoOct 30, 2013
  19. Thomas RastOct 30, 2013
  20. Junio C HamanoOct 30, 2013
  21. 2/7 gitk: refactor per-line part of getblobdiffline and its supportThomas Rast, Oct 29, 2013
  22. 3/7 gitk: split out diff part in $commitinfoThomas Rast, Oct 29, 2013
  23. 4/7 gitk: support showing the gathered inline diffsThomas Rast, Oct 29, 2013
  24. 5/7 gitk: recognize -L optionThomas Rast, Oct 29, 2013
  25. 6/7 Documentation: put blame/log -L in sticked formThomas Rast, Oct 29, 2013
  26. Junio C HamanoOct 30, 2013
  27. Thomas RastOct 30, 2013
  28. Junio C HamanoOct 30, 2013
  29. Thomas RastOct 30, 2013
  30. Junio C HamanoOct 30, 2013
  31. 0/5 gitk -LThomas Rast, Nov 16, 2013
  32. 1/5 gitk: support -G option from the command lineThomas Rast, Nov 16, 2013
  33. 2/5 gitk: refactor per-line part of getblobdiffline and its supportThomas Rast, Nov 16, 2013
  34. 3/5 gitk: split out diff part in $commitinfoThomas Rast, Nov 16, 2013
  35. 4/5 gitk: support showing the gathered inline diffsThomas Rast, Nov 16, 2013
  36. 5/5 gitk: recognize -L optionThomas Rast, Nov 16, 2013
  37. Paul MackerrasDec 1, 2013
  38. 0/3 Documentation: stuck arguments and gitk log -LThomas Rast, Nov 16, 2013
  39. 1/3 commit-tree: use prefixcmp instead of memcmp(..., N)Thomas Rast, Nov 16, 2013
  40. 2/3 Documentation: convert to --option=arg form where possibleThomas Rast, Nov 16, 2013
  41. 3/3 Documentation/gitk: document -L optionThomas Rast, Nov 16, 2013
  42. 7/7 Documentation/gitk: document -L optionThomas Rast, Oct 29, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.