git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/2] Revert --valgrind-parallel test option

From
Thomas Rast <tr@thomasrast.ch>
Date
Oct 19, 2013, 21:06 UTC
Message-ID
<cover.1382215973.git.tr@thomasrast.ch>

These patches remove the --valgrind-parallel=N option that was broken from the outset (shame on me). Peff's judgement at the time that its usefulness would approximately be "meh" turns out to be correct.

What's not in the commit message, but drives part of my reasoning in doing a revert instead of a fix: I did fix it up locally only to notice that it was too slow in this case for what I actually wanted to use it for. The only valgrind-test workflow that I find bearable is to run all the tests in the background under prove (takes hours), and then use the prove output (which says exactly which subtests fail) in --valgrind-only=<subtest>. So the latter is -- again Peff was right -- the really useful thing.

The only consolation is that I apparently didn't break any other use of the test suite -- otherwise it would presumably have been fixed very quickly.

Thomas Rast (2):
  Revert "test-lib: support running tests under valgrind in parallel"
  Revert "test-lib: allow prefixing a custom string before "ok N" etc."
 t/test-lib.sh | 133 +++++++++++++++-------------------------------------------
 1 file changed, 34 insertions(+), 99 deletions(-)
-- 
1.8.4.1.810.g312044e
Next: Thomas Rast
Message 1 of 3 in “Revert --valgrind-parallel test option”
  1. 0/2 Revert --valgrind-parallel test optionThomas Rast, Oct 19, 2013
  2. 1/2 Revert "test-lib: support running tests under valgrind in parallel"Thomas Rast, Oct 19, 2013
  3. 2/2 Revert "test-lib: allow prefixing a custom string before "ok N" etc."Thomas Rast, Oct 19, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.