git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/3] make builtin-commit use commit_tree() and reduce_heads()

From
Miklos Vajna <vmiklos@frugalware.org>
Date
Sep 10, 2008, 20:10 UTC
Message-ID
<cover.1221077214.git.vmiklos@frugalware.org>
Hi,
On Tue, Sep 09, 2008 at 05:52:37PM +0100, Russell King <rmk@arm.linux.org.uk> wrote:
> Is this intentional, or is it a bug?

It is because builtin-commit does not use reduce_heads(), but builtin-merge does.

Here are 3 patches to make builtin-commit use commit_tree() and reduce_heads() as well.

The first one just improves the commit_tree() interface.

The second one is a cleanup, but it also adds reduce_heads() usage, to fix the issue, pointed out by Russell King.

The third one adds new testcases, based on the ones provided by him.
Miklos Vajna (3):
  commit_tree(): add a new author parameter
  builtin-commit: use commit_tree()
  t7603: add new testcases to ensure builtin-commit uses reduce_heads()
 builtin-commit-tree.c         |    9 ++++--
 builtin-commit.c              |   63 +++++++++-------------------------------
 builtin-merge.c               |    4 +-
 builtin.h                     |    3 +-
 t/t7603-merge-reduce-heads.sh |   53 ++++++++++++++++++++++++++++++++++
 5 files changed, 77 insertions(+), 55 deletions(-)
Next: Miklos Vajna
Message 1 of 4 in “make builtin-commit use commit_tree() and reduce_heads()”
  1. 0/3 make builtin-commit use commit_tree() and reduce_heads()Miklos Vajna, Sep 10, 2008
  2. 1/3 commit_tree(): add a new author parameterMiklos Vajna, Sep 10, 2008
  3. 2/3 builtin-commit: use commit_tree()Miklos Vajna, Sep 10, 2008
  4. 3/3 t7603: add new testcases to ensure builtin-commit uses reduce_heads()Miklos Vajna, Sep 10, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.