git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 0/2] show-brach: segfault fix from Gregory David

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Apr 21, 2022, 15:33 UTC
Message-ID
<cover-v3-0.2-00000000000-20220421T152704Z-avarab@gmail.com>
In-Reply-To
<225b410d-2d98-8c0b-c289-22f753c175d4@p1sec.com>

This is a version of https://lore.kernel.org/git/225b410d-2d98-8c0b-c289-22f753c175d4@p1sec.com/ that applies with "git am", the patch got munged in transit (from the looks of it from Thunderbird's wrapping).

I added a 1/2 to factor out some shared code used by the segfault fix, and made the now-smaller 2/2 use that function.

I also renamed some varibles to reduce wrapping, and made the append_one_rev() come after the ref formatting. Other similar code above does that, it looks to me like they're equivalent (append_one_rev increments ref_name_cnt).

Gregory David (1):
  show-branch: fix SEGFAULT when `--current` and `--reflog` together
Ævar Arnfjörð Bjarmason (1):
  show-branch: refactor in preparation for next commit
 builtin/show-branch.c  | 47 ++++++++++++++++++++++++++++++------------
 t/t3202-show-branch.sh | 43 ++++++++++++++++++++++++++++++++++++++
 2 files changed, 77 insertions(+), 13 deletions(-)
-- 
2.36.0.876.g7efc8a7728c
Previous: Gregory DavidNext: Ævar Arnfjörð Bjarmason
Message 2 of 7 in “show-branch: fix SEGFAULT when `--current` and `--reflog` together”
  1. show-branch: fix SEGFAULT when `--current` and `--reflog` togetherGregory David, Apr 21, 2022
  2. 0/2 show-brach: segfault fix from Gregory DavidÆvar Arnfjörð Bjarmason, Apr 21, 2022
  3. 1/2 show-branch: refactor in preparation for next commitÆvar Arnfjörð Bjarmason, Apr 21, 2022
  4. Junio C HamanoApr 21, 2022
  5. 2/2 show-branch: fix SEGFAULT when `--current` and `--reflog` togetherÆvar Arnfjörð Bjarmason, Apr 21, 2022
  6. Junio C HamanoApr 21, 2022
  7. show-branch: -g and --current are incompatibleJunio C Hamano, Apr 21, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.