[PATCH v2 0/7] leak tests: fix "test-tool" & other small leaks
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Oct 7, 2021, 10:01 UTC
- Message-ID
- <cover-v2-0.7-00000000000-20211007T100014Z-avarab@gmail.com>
- In-Reply-To
- <cover-0.7-00000000000-20211006T095426Z-avarab@gmail.com>
Like my just-submitted series to mark existing tests as passing[1] under the test mode added in ab/sanitize-leak-ci, this marks more tests as passing, but here we need to fix some small memory leaks. This goes on top of ab/sanitize-leak-ci.
See v1[1] for a more detailed summary, the only update here is to some bad commit message grammar/phrasing in v1.
1. https://lore.kernel.org/git/cover-0.7-00000000000-20211006T095426Z-avarab@gmail.com/
Ævar Arnfjörð Bjarmason (7): tests: fix a memory leak in test-prio-queue.c tests: fix a memory leak in test-parse-options.c tests: fix a memory leak in test-oidtree.c tests: fix test-oid-array leak, test in SANITIZE=leak ls-files: fix a trivial dir_clear() leak ls-files: add missing string_list_clear() merge: add missing strbuf_release()
builtin/ls-files.c | 14 ++++++-------- builtin/merge.c | 2 ++ t/helper/test-oid-array.c | 4 ++++ t/helper/test-oidtree.c | 3 +++ t/helper/test-parse-options.c | 7 ++++++- t/helper/test-prio-queue.c | 2 ++ t/t0009-prio-queue.sh | 2 ++ t/t0040-parse-options.sh | 1 + t/t0064-oid-array.sh | 2 ++ t/t0069-oidtree.sh | 1 + t/t3001-ls-files-others-exclude.sh | 5 +++-- t/t3005-ls-files-relative.sh | 1 + t/t3020-ls-files-error-unmatch.sh | 2 ++ t/t3700-add.sh | 1 + t/t7104-reset-hard.sh | 1 + t/t7604-merge-custom-message.sh | 1 + 16 files changed, 38 insertions(+), 11 deletions(-)
Range-diff against v1:
1: 8806f9cb5e8 = 1: 37cdf0ee348 tests: fix a memory leak in test-prio-queue.c
2: c24e115aa49 ! 2: 53b0da60804 tests: fix a memory leak in test-parse-options.c
@@ Commit message
tests: fix a memory leak in test-parse-options.c
Fix a memory leak in t/helper/test-parse-options.c, we were not
- freeing the allocated "struct string_list" or its items. While I'm at
- it move the declaration of the "list" string_list the
- cmd__parse_options() function.
+ freeing the allocated "struct string_list" or its items. Let's move
+ the declaration of the "list" variable into the cmd__parse_options()
+ and release it at the end.
In c8ba1639165 (parse-options: add OPT_STRING_LIST helper, 2011-06-09)
the "list" variable was added, and later on in
3: a216297aba1 = 3: 33a4b9c7c68 tests: fix a memory leak in test-oidtree.c
4: 4aa2a70c67e = 4: b8ce8d7e972 tests: fix test-oid-array leak, test in SANITIZE=leak
5: 58b5bc67435 = 5: 73cf1018953 ls-files: fix a trivial dir_clear() leak
6: 34749645f74 = 6: fc10353c0c5 ls-files: add missing string_list_clear()
7: d7c94fa2851 = 7: 9942c084244 merge: add missing strbuf_release()-- 2.33.0.1446.g6af949f83bd