[PATCH 0/9] test-tool: fix memory leaks
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Jun 30, 2022, 23:47 UTC
- Message-ID
- <cover-0.9-00000000000-20220630T180129Z-avarab@gmail.com>
This is a series of trivial leak-fixes which allows us to mark various tests as entirely passing under SANITIZE=leak, the reasn they weren't passing before was because we'd spot memory leaks in test-tool, rather than git itself.
This is a sibling series to my just-submitted series for fixing memory leaks in built-ins[1], but the the two do not textually or semantically conflict.
There are still a few other test-tool memory leaks, but these are the ones I had patches ready for, having focused on trying to get t00*.sh passing first, and then picking some low-hanging fruit after that.
Passing CI for this series can be found at [2].
1. https://lore.kernel.org/git/cover-00.11-00000000000-20220630T175714Z-avarab@gmail.com/ 2. https://github.com/avar/git/tree/avar/test-tool-memory-leaks
Ævar Arnfjörð Bjarmason (9):
test-tool test-hash: fix a memory leak
test-tool path-utils: fix a memory leak
test-tool {dump,scrap}-cache-tree: fix memory leaks
test-tool urlmatch-normalization: fix a memory leak
test-tool regex: call regfree(), fix memory leaks
test-tool json-writer: fix memory leaks
test-tool bloom: fix a memory leak
test-tool ref-store: fix a memory leak
test-tool delta: fix a memory leakt/helper/test-bloom.c | 2 ++ t/helper/test-delta.c | 21 +++++++++----- t/helper/test-dump-cache-tree.c | 7 ++++- t/helper/test-hash.c | 1 + t/helper/test-json-writer.c | 16 ++++++++--- t/helper/test-path-utils.c | 10 +++++-- t/helper/test-ref-store.c | 1 + t/helper/test-regex.c | 40 ++++++++++++++++---------- t/helper/test-scrap-cache-tree.c | 1 + t/helper/test-urlmatch-normalization.c | 11 +++++-- t/t0015-hash.sh | 3 +- t/t0019-json-writer.sh | 2 ++ t/t0060-path-utils.sh | 1 + t/t0090-cache-tree.sh | 2 ++ t/t0095-bloom.sh | 2 +- t/t0110-urlmatch-normalization.sh | 2 ++ t/t5303-pack-corruption-resilience.sh | 2 ++ t/t5308-pack-detect-duplicates.sh | 2 ++ t/t5309-pack-delta-cycles.sh | 2 ++ t/t5321-pack-large-objects.sh | 2 ++ t/t7812-grep-icase-non-ascii.sh | 1 + 21 files changed, 97 insertions(+), 34 deletions(-)
-- 2.37.0.874.g7d3439f13c4