[PATCH 0/7] help: test and fix small "help -g" regression
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Dec 28, 2021, 15:35 UTC
- Message-ID
- <cover-0.7-00000000000-20211228T153456Z-avarab@gmail.com>
Fix a trivial regression in 17b3e515050 (Merge branch 'nd/command-list' into nd/complete-config-vars, 2018-05-29) where we'd overly whitespace pad "git help -g", since the codepath moved to a function that assumed it needed to "\n\n"-pad multiple items being emitted, so we'd print an extra leading newline when printing one item (as opposed to "git help -a").
In doing so I wanted to add regression tests, and to do that we first need to make the format stable ("git help -a" will change depending on whatever git-* you have in $PATH).
These are things I noticed when re-rolling my no-yet-picked-up series to move Documentation/technical/* to manpages[1]. An unsubmitted re-roll of this series depends on this one. I'll hold off on a re-submission of it until this series has graduated.
1. https://lore.kernel.org/git/cover-v2-0.5-00000000000-20211212T194047Z-avarab@gmail.com/
Ævar Arnfjörð Bjarmason (7):
help doc: add missing "]" to "[-a|--all]"
help.c: use puts() instead of printf{,_ln}() for consistency
help tests: test "git" and "git help [-a|-g] spacing
help.c: split up list_all_cmds_help() function
help: error if [-a|-g|-c] and [-i|-m|-w] are combined
help: add --no-[external-commands|aliases] for use with --all
help: don't print "\n" before single-section outputDocumentation/git-help.txt | 12 ++++- builtin/help.c | 34 ++++++++++++-- help.c | 37 ++++++++++++---- help.h | 2 +- t/t0012-help.sh | 91 ++++++++++++++++++++++++++++++++++++++ 5 files changed, 161 insertions(+), 15 deletions(-)
-- 2.34.1.1257.g2af47340c7b