git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/5] streaming.c: refactor for smaller + easier to understand code

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
May 5, 2021, 12:33 UTC
Message-ID
<cover-0.5-00000000000-20210505T122816Z-avarab@gmail.com>

This is a prep series for my yet-to-be-sent re-roll of [1], aka. ab/fsck-unexpected-type.

Jeff King had a comment in [2] saying it was odd to have an "oi2" variable, that was because there was on an "oi" name already defined via the new-gone open_method_decl(loose) macro. As we'll see we could do without the initial "oi" and a few other types of indirection in this interface.

Junio: Could you eject ab/fsck-unexpected-type while this is being
considered/cooked? I didn't really see how to address Jeff's feedback
about that variable name in a way that wouldn't just make something
like this refactoring part of an even bigger series. I think ejecting
the functional changes & trying to get this in first is the least
worst approach at this point. Eventually I'll submit a re-roll of
ab/fsck-unexpected-type either based on this, or master (if it's
landed already).
1. https://lore.kernel.org/git/cover-0.6-00000000000-20210413T093734Z-avarab@gmail.com/#t
2. https://lore.kernel.org/git/YILZHiuUyj0mt958@coredump.intra.peff.net/
Ævar Arnfjörð Bjarmason (5):
  streaming.c: avoid forward declarations
  streaming.c: remove enum/function/vtbl indirection
  streaming.c: remove {open,close,read}_method_decl() macros
  streaming.c: stop passing around "object_info *" to open()
  streaming.c: move {open,close,read} from vtable to "struct
    git_istream"
 streaming.c | 268 ++++++++++++++++++++++------------------------------
 1 file changed, 115 insertions(+), 153 deletions(-)
-- 
2.31.1.838.g7ac6e98bb53
Next: Ævar Arnfjörð Bjarmason
Message 1 of 12 in “streaming.c: refactor for smaller + easier to understand code”
  1. 0/5 streaming.c: refactor for smaller + easier to understand codeÆvar Arnfjörð Bjarmason, May 5, 2021
  2. 1/5 streaming.c: avoid forward declarationsÆvar Arnfjörð Bjarmason, May 5, 2021
  3. 3/5 streaming.c: remove {open,close,read}_method_decl() macrosÆvar Arnfjörð Bjarmason, May 5, 2021
  4. Jeff KingMay 5, 2021
  5. 2/5 streaming.c: remove enum/function/vtbl indirectionÆvar Arnfjörð Bjarmason, May 5, 2021
  6. Jeff KingMay 5, 2021
  7. Junio C HamanoMay 6, 2021
  8. 5/5 streaming.c: move {open,close,read} from vtable to "struct git_istream"Ævar Arnfjörð Bjarmason, May 5, 2021
  9. Jeff KingMay 5, 2021
  10. 4/5 streaming.c: stop passing around "object_info *" to open()Ævar Arnfjörð Bjarmason, May 5, 2021
  11. Jeff KingMay 5, 2021
  12. Jeff KingMay 5, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.