git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/3] commit-graph: make "verify" work with replace refs

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Oct 14, 2021, 23:37 UTC
Message-ID
<cover-0.3-00000000000-20211014T233343Z-avarab@gmail.com>

This changes "commit-graph verify" to ignore replace refs, as "commit-graph write" already does.

The 3/3 is a rather simple fix, and unblocks another series that wants to fix the GIT_TEST_COMMIT_GRAPH mode.

1-2/3 are fixes to existing commit-graph tests. I just wanted to use the "graph_git_two_modes" helper, but it was broken, including in a way that hid an existing failure in a years-old test.

Glen: I've tested this with your v4 series with that
"GIT_TEST_COMMIT_GRAPH=0" part of the mktag tests removed, and they
pass on top of this with GIT_TEST_COMMIT_GRAPH=true.
Ævar Arnfjörð Bjarmason (3):
  commit-graph tests: fix error-hiding graph_git_two_modes() helper
  commit-graph tests: fix another graph_git_two_modes() helper
  commit-graph: don't consider "replace" objects with "verify"
 builtin/commit-graph.c        |  2 +-
 t/t5318-commit-graph.sh       |  5 +++--
 t/t5324-split-commit-graph.sh | 20 ++++++++++++--------
 3 files changed, 16 insertions(+), 11 deletions(-)
-- 
2.33.1.1338.g20da966911a
Next: Ævar Arnfjörð Bjarmason
Message 1 of 7 in “commit-graph: make "verify" work with replace refs”
  1. 0/3 commit-graph: make "verify" work with replace refsÆvar Arnfjörð Bjarmason, Oct 14, 2021
  2. 1/3 commit-graph tests: fix error-hiding graph_git_two_modes() helperÆvar Arnfjörð Bjarmason, Oct 14, 2021
  3. Junio C HamanoOct 15, 2021
  4. 2/3 commit-graph tests: fix another graph_git_two_modes() helperÆvar Arnfjörð Bjarmason, Oct 14, 2021
  5. Junio C HamanoOct 15, 2021
  6. 3/3 commit-graph: don't consider "replace" objects with "verify"Ævar Arnfjörð Bjarmason, Oct 14, 2021
  7. Junio C HamanoOct 15, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.