git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/3] fetch: fix segfault, missing docs in --negotiate-only

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Jun 30, 2021, 16:38 UTC
Message-ID
<cover-0.3-00000000000-20210630T163329Z-avarab@gmail.com>

The recently added --negotiate-only option segfaults when not combined with --negotiation-tip=*, this fixes that, and adds documentation for it.

1/3 is a related fix to save us some work in a codepath checking the "--negotiate-only" and other passed-in options in send-pack.c.

Ævar Arnfjörð Bjarmason (3):
  send-pack.c: move "no refs in common" abort earlier
  fetch: document the --negotiate-only option
  fetch: fix segfault in --negotiate-only without --negotiation-tip=*
 Documentation/config/fetch.txt  |  3 ++-
 Documentation/fetch-options.txt | 13 +++++++++++--
 builtin/fetch.c                 |  3 +++
 send-pack.c                     | 11 ++++++-----
 t/t5702-protocol-v2.sh          | 17 +++++++++++++++++
 5 files changed, 39 insertions(+), 8 deletions(-)
-- 
2.32.0.619.g53a98c35da0
Next: Ævar Arnfjörð Bjarmason
Message 1 of 9 in “fetch: fix segfault, missing docs in --negotiate-only”
  1. 0/3 fetch: fix segfault, missing docs in --negotiate-onlyÆvar Arnfjörð Bjarmason, Jun 30, 2021
  2. 1/3 send-pack.c: move "no refs in common" abort earlierÆvar Arnfjörð Bjarmason, Jun 30, 2021
  3. 3/3 fetch: fix segfault in --negotiate-only without --negotiation-tip=*Ævar Arnfjörð Bjarmason, Jun 30, 2021
  4. Jonathan TanJun 30, 2021
  5. 2/3 fetch: document the --negotiate-only optionÆvar Arnfjörð Bjarmason, Jun 30, 2021
  6. 0/3 fetch: fix segfault, missing docs in --negotiate-onlyÆvar Arnfjörð Bjarmason, Jul 8, 2021
  7. 1/3 send-pack.c: move "no refs in common" abort earlierÆvar Arnfjörð Bjarmason, Jul 8, 2021
  8. 2/3 fetch: document the --negotiate-only optionÆvar Arnfjörð Bjarmason, Jul 8, 2021
  9. 3/3 fetch: fix segfault in --negotiate-only without --negotiation-tip=*Ævar Arnfjörð Bjarmason, Jul 8, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.