Feature suggestion: support arguments for GIT_PROXY_COMMAND & core.gitproxy
- From
- Joey Korkames <joey+floss@kidfixit.com>
- Date
- Dec 18, 2009, 23:39 UTC
- Message-ID
- <cone.1261179562.490491.4033.1000@toolshiner.phx1.kidfixit.com>
Could /connect.c be patched to support multiple arguments in ENV[GIT_PROXY_COMMAND] and git config core.gitproxy?
For instance, something like : GIT_PROXY_COMMAND="myproxyscript arg1 arg2"
or (way more useful): git config core.gitproxy \ '"myproxyscript -mode git -proxy joey@gw.myhouse.com -proxy joey@bastion.foocorp.com" for foocorp.com$'
Its slightly annoying to maintain and distribute custom copies of myproxyscript that carry the repo-specific proxy arguments inline just because git won't pass those arguments itself (arguments that a repo's .git/config can easily store).
I think supporting tokens (ala ssh's ProxyCommand - %h=repohost, %p=repoport, %u=repouser) would be awesome, but that change would not be backward-compatible with existing .git/config files or GIT_PROXY_COMMAND utilizing-scripts. Its enough to assume that "$host $port" will always be appended to the gitproxy arg list.
Thanks for reading, (and thnaks for git!) -joey