Re: [PATCH] replace 'test -[efd]' with 'test_path_is_[file,dir,executable]'

From: Carlo Marcelo Arenas Belón <carenas@gmail.com>
Date: Jun 16, 2025, 03:53 UTC
Message-ID: <cioavyfxwgdhfzuodb7dnwzmvsui4xcxi6mljnlszjwebogajg@taejma43hgtx>
In-Reply-To: <20250616020827.10820-1-rodmichelassi@gmail.com>

On Sun, Jun 15, 2025 at 11:08:27PM -0800, Rodrigo Michelassi wrote:

> From: rodrigocmichelassi <rodmichelassi@gmail.com>
> 
> 'test_path_is_file', 'test_path_is_dir' and 'test_file_is_executable' are modern path checking methods in Git's development. Replace the basic shell commands 'test -f', 'test -d' and 'test -e', respectively, with this approach

Splitting this long line, into multiple lines of about 70ish columns is better, see the relevant documents in Documentation/ for useful suggestions.

> Signed-off-by: Rodrigo Michelassi <rodmichelassi@gmail.com>

This certifies that you are the author of the code, an therefore should go after Isabella's, who might be the original author which you improved upon.

Show 6 quoted lines

> @@ -474,7 +474,7 @@ test_expect_success 'local clone --shared from linked checkout' '
>  
>  test_expect_success '"add" worktree with --no-checkout' '
>  	git worktree add --no-checkout -b swamp swamp &&
> -	! test -e swamp/init.t &&
> +	! test_path_is_executable swamp/init.t &&

this is not acurate translation, `test -e` is true if there is any "file" with that name, the equivalent for that helper function would be `test -x`

Carlo