git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/1] commit: make the sign-off trailer configurable

From
Derrick Stolee <stolee@gmail.com>
Date
Jan 6, 2020, 19:53 UTC
Message-ID
<cfa40ca5-98a1-fc9c-9ccc-f14b81119e60@gmail.com>
In-Reply-To
<xmqqtv58a5m2.fsf@gitster-ct.c.googlers.com>
On 1/6/2020 11:53 AM, Junio C Hamano wrote:
Show 16 quoted lines
> Derrick Stolee <stolee@gmail.com> writes:
> 
>> My initial thought was that the sign-off was supposed to be a purposeful
>> decision, but then I also realized that I never do anything in the Git
>> codebase that I _can't_ put online under the GPL. (It may not make it
>> upstream, but it will always be put online somewhere.)
> 
> Hmm...
> 
> Sorry, but I do not quite understand the flow of your logic here,
> especially, how "but then I also realized" trumps "signing off a
> patch is a conscious act---it would weaken the legal meaning if you
> automate it", which was why we deliberately avoided adding this
> configuration variable for the last 10+ years.
> 
> So, I dunno.

I guess I meant that enabling this config for a repo is also a conscious act, making me think this is not completely unreasonable.

But if we've already discussed and rejected this feature in the past, then that's sufficient.

Since I started the line of "this isn't a bad idea" I'll follow up with the historical search. Here are previous attempts from 2018 [1], 2015 [2], 2010 [3].

Thanks, -Stolee

[1] https://lore.kernel.org/git/20180204020318.4363-1-chenjingpiao@gmail.com/ [2] https://lore.kernel.org/git/1435217454-5718-1-git-send-email-cmarcelo@gmail.com/ [3] https://lore.kernel.org/git/alpine.LNX.2.00.1001131635510.16395@vqena.qenxr.bet.am/

Previous: Junio C HamanoNext: Junio C Hamano
Message 5 of 7 in “commit: make the sign-off trailer configurable”
  1. 0/1 commit: make the sign-off trailer configurableHans Jerry Illikainen, Jan 5, 2020
  2. 1/1 commit: make the sign-off trailer configurableHans Jerry Illikainen, Jan 5, 2020
  3. Derrick StoleeJan 6, 2020
  4. Junio C HamanoJan 6, 2020
  5. Derrick StoleeJan 6, 2020
  6. Junio C HamanoJan 6, 2020
  7. Junio C HamanoJan 6, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.