[PATCH 5/5] parseopt: restore const qualifier to parsed filename
- From
D. Ben Knoble <ben.knoble+github@gmail.com>
- Date
- Nov 2, 2025, 16:17 UTC
- Message-ID
- <cedd4c3dbf448ae479bca109f74e1dd6f64cac72.1762100242.git.ben.knoble+github@gmail.com>
- In-Reply-To
- <cover.1762100242.git.ben.knoble+github@gmail.com>
This was unintentionally dropped in ccfcaf399f (parseopt: values of pathname type can be prefixed with :(optional), 2025-09-28). Notably, continue dropping the const qualifier when free'ing value; see 4049b9cfc0 (fix const issues with some functions, 2007-10-16) or 83838d5c1b (cast variable in call to free() in builtin/diff.c and submodule.c, 2011-11-06) for more details on why.
Suggested-by: Phillip Wood <phillip.wood@dunelm.org.uk> Signed-off-by: D. Ben Knoble <ben.knoble+github@gmail.com> --- parse-options.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/parse-options.c b/parse-options.c index 197c01987e..be3d8f6599 100644 --- a/parse-options.c +++ b/parse-options.c @@ -213,7 +213,7 @@ static enum parse_opt_result do_get_value(struct parse_opt_ctx_t *p, if (unset) value = NULL; else if (opt->flags & PARSE_OPT_OPTARG && !p->opt) - value = (char *)opt->defval; + value = (const char *)opt->defval; else { int err = get_arg(p, opt, flags, &value); if (err)
-- 2.48.1