Re: [PATCH 4/9] run-command: add support for timeout in command finisher
- From
Siddh Raman Pant <siddh.raman.pant@oracle.com>
- Date
- May 22, 2026, 05:46 UTC
- Message-ID
- <cea0975e77d8167c0bceab8a45acf6882910a74b.camel@oracle.com>
- In-Reply-To
- <xmqqv7cgxq0o.fsf@gitster.g>
On Fri, May 22 2026 at 05:40:47 +0530, Junio C Hamano wrote:
Show 9 quoted lines
> If a protocol builds its own way to declare "this backend is slow, > so please do not consider less than 3 seconds of nonaction something > to worry about but kill it off if you waited more than that" to make > the receiving/waiting end responsible for managing timeout, that > might be workable, but it certainly feels like a kludge. The > protocol can instead allow an "error - for your particular request, > we couldn't come up with an answer within a reasonable time limit" > response (in practice, "within time limit" does not have to be the > only reason for such an error) to be returned, I think.
I think we are confusing two different commits here.
The response read deadline is the next commit. This commit is about force-killing a process if it doesn't respond to the initial termination signal.
Thanks, Siddh