Re: Git Test Coverage Report for v2.37.0-rc0

From: Derrick Stolee <derrickstolee@github.com>
Date: Jun 14, 2022, 20:34 UTC
Message-ID: <cdc0cba8-bd9d-9299-a769-aa7b522520ae@github.com>
In-Reply-To: <3d1c6dfd-1df6-3393-df5e-692719375772@github.com>

On 6/14/2022 4:20 PM, Derrick Stolee wrote:

Show 8 quoted lines

> On 6/14/2022 4:18 PM, Derrick Stolee wrote:
>> Derrick Stolee	b56166ca multi-pack-index: use --object-dir real path
>> builtin/multi-pack-index.c
>> b56166ca 61) opts.object_dir = xstrdup(get_object_directory());
> 
> This is demonstrating that opts.object_dir is never populated before
> we parse the options. We must be handling a NULL object_dir properly
> somewhere else. I'll work on a patch to fix this.

I was looking at the wrong line. This line is testing the --no-object-dir option, which is fine to leave untested, probably.

Thanks, -Stolee