[PATCH] upload-archive: monitor child communication even more carefully.
- From
- Franck Bui-Huu <vagabon.xyz@gmail.com>
- Date
- Sep 17, 2006, 14:09 UTC
- Message-ID
- <cda58cb80609170709l1f2732d4s2c606aeafd6b9257@mail.gmail.com>
The current code works like this: if others flags than POLLIN is raised we assume that (a) something bad happened and the child died or (b) the child has closed the pipe because it had no more data to send.
For the latter case, we assume wrongly that one call to process_input() will empty the pipe. Indeed it reads only 16Ko of data by call and the the pipe capacity can be larger than that (on current Linux kernel, it is 65536 bytes). Therefore the child can write 32ko of data, for example, and close the pipe. After that poll will return POLLIN _and_ POLLHUP and the parent will read only 16ko of data.
This patch forces the parent to empty the pipe as soon as POLLIN is raised and even if POLLHUP or something else is raised too.
Moreover, some implementations of poll might return POLLRDNORM flag even if it is non standard.
Signed-off-by: Franck Bui-Huu <vagabon.xyz@gmail.com> ---
My own fault.
builtin-upload-archive.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/builtin-upload-archive.c b/builtin-upload-archive.c index 115a12d..0596865 100644 --- a/builtin-upload-archive.c +++ b/builtin-upload-archive.c @@ -160,7 +160,8 @@ int cmd_upload_archive(int argc, const c if (pfd[1].revents & POLLIN) /* Status stream ready */ process_input(pfd[1].fd, 2); - if ((pfd[0].revents | pfd[1].revents) == POLLIN) + /* Always finish to read data when available */ + if ((pfd[0].revents | pfd[1].revents) & POLLIN) continue; if (waitpid(writer, &status, 0) < 0)
-- 1.4.2.1.gcd6f1-dirty