Re: [PATCH 1/2] archive: allow remote to have more formats than we understand.

From: Franck Bui-Huu <vagabon.xyz@gmail.com>
Date: Sep 10, 2006, 19:18 UTC
Message-ID: <cda58cb80609101218m35e3ac97y5668017d2c03948f@mail.gmail.com>
In-Reply-To: <7vwt8br150.fsf@assigned-by-dhcp.cox.net>

2006/9/10, Junio C Hamano <junkio@cox.net>:

Show 11 quoted lines

> "Franck Bui-Huu" <vagabon.xyz@gmail.com> writes:
>
> >> +static const char *remote_request(int *ac, const char **av)
> >> +{
> >
> > just to be consistent with the rest of the file, I would have called
> > this function
> > "parse_remote_arg" or "extract_remote_arg"
>
> I was thinking about calling this is_remote_request() actually.
>

that sounds like to return a boolean. You would need to pass remote as a parameter, no ? I think extract_remote_arg is nice because it tells you that it returns remote option valu _and_ remove it from argv.

-- 
               Franck