git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] t3650: use option with value consistenly with equal sign

From
KHKristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date
Mar 23, 2026, 19:17 UTC
Message-ID
<ccc995f1-4da2-468a-97d6-f20993ca4b4c@app.fastmail.com>
In-Reply-To
<20260323-toon-replay-arbitrary-ref-v1-1-5c7172f675ec@iotcl.com>
On Mon, Mar 23, 2026, at 17:09, Toon Claes wrote:
> The tests in t3650-replay-basics have mixed use of option arguments
> with value with and without equal sign. Bring in consistency and use
> equal sign for all options that expect a value.

If it is about consistency, could you pick one or the other either way or go with whatever happened to be most used right now?

Consistency by itself is a weaker argument than arguing that stuck form is better for invoking git(1) commands, which is what gitcli(7) argues.

Which is to say: arguing for stuck form in the commit message based on it being better is a stronger argument than wanting consistency. :)

Then once one form has been argued for or referenced it follows that you should be consistent and use the best approach throughout.

> This makes it easier to distinguish them from positional arguments.

Maybe it’s just me, but sticking with the stuck form makes it harder to mess up writing unintended options and positional arguments. Once written it might be slightly more readable, but the main benefit is using a style that makes messing up harder to pull off.

Show 6 quoted lines
>
> Signed-off-by: Toon Claes <toon@iotcl.com>
> ---
>  t/t3650-replay-basics.sh | 70 ++++++++++++++++++++++++------------------------
>  1 file changed, 35 insertions(+), 35 deletions(-)
>[snip]
Previous: Toon ClaesNext: Junio C Hamano
Message 3 of 25 in “Add option --ref to git-replay(1)”
  1. 0/3 Add option --ref to git-replay(1)Toon Claes, Mar 23, 2026
  2. 1/3 t3650: use option with value consistenly with equal signToon Claes, Mar 23, 2026
  3. Kristoffer HaugsbakkMar 23, 2026
  4. Junio C HamanoMar 23, 2026
  5. Toon ClaesMar 25, 2026
  6. 2/3 builtin/replay: improve documentation on optionsToon Claes, Mar 23, 2026
  7. 3/3 replay: allow to specify a ref with option --refToon Claes, Mar 23, 2026
  8. Tian YuchenMar 23, 2026
  9. Toon ClaesMar 25, 2026
  10. Kristoffer HaugsbakkMar 23, 2026
  11. Toon ClaesMar 25, 2026
  12. 0/3 Add option --ref to git-replay(1)Toon Claes, Mar 25, 2026
  13. 1/3 builtin/replay: mark options as not negatableToon Claes, Mar 25, 2026
  14. 2/3 replay: use stuck form in documentation and help messageToon Claes, Mar 25, 2026
  15. 3/3 replay: allow to specify a ref with option --refToon Claes, Mar 25, 2026
  16. Junio C HamanoMar 25, 2026
  17. Toon ClaesMar 31, 2026
  18. Junio C HamanoMar 25, 2026
  19. Junio C HamanoMar 26, 2026
  20. Toon ClaesMar 31, 2026
  21. Junio C HamanoMar 31, 2026
  22. 0/3 Add option --ref to git-replay(1)Toon Claes, Apr 1, 2026
  23. 1/3 builtin/replay: mark options as not negatableToon Claes, Apr 1, 2026
  24. 2/3 replay: use stuck form in documentation and help messageToon Claes, Apr 1, 2026
  25. 3/3 replay: allow to specify a ref with option --refToon Claes, Apr 1, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.