git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/1] mingw: fix CPU reporting in `git version --build-options`

From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Date
Feb 7, 2019, 10:46 UTC
Message-ID
<cca9a543d52f3d7d9015709800e10ea57be1fea3.1549536364.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.121.git.gitgitgadget@gmail.com>
From: Johannes Schindelin <johannes.schindelin@gmx.de>

We cannot rely on `uname -m` in Git for Windows' SDK to tell us what architecture we are compiling for, as we can compile both 32-bit and 64-bit `git.exe` from a 64-bit SDK, but the `uname -m` in that SDK will always report `x86_64`.

So let's go back to our original design. And make it explicitly Windows-specific.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 compat/mingw.h | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
diff --git a/compat/mingw.h b/compat/mingw.h
index 30d9fb3e36..98407744f2 100644
--- a/compat/mingw.h
+++ b/compat/mingw.h
@@ -6,6 +6,25 @@ typedef _sigset_t sigset_t;
 #include <winsock2.h>
 #include <ws2tcpip.h>
 
+#ifdef __MINGW64_VERSION_MAJOR
+/*
+ * In Git for Windows, we cannot rely on `uname -m` to report the correct
+ * architecture: /usr/bin/uname.exe will report the architecture with which the
+ * current MSYS2 runtime was built, not the architecture for which we are
+ * currently compiling (both 32-bit and 64-bit `git.exe` is built in the 64-bit
+ * Git for Windows SDK).
+ */
+#undef GIT_HOST_CPU
+/* This was figured out by looking at `cpp -dM </dev/null`'s output */
+#if defined(__x86_64__)
+#define GIT_HOST_CPU "x86_64"
+#elif defined(__i686__)
+#define GIT_HOST_CPU "i686"
+#else
+#error "Unknown architecture"
+#endif
+#endif
+
 /* MinGW-w64 reports to have flockfile, but it does not actually have it. */
 #ifdef __MINGW64_VERSION_MAJOR
 #undef _POSIX_THREAD_SAFE_FUNCTIONS
-- 
gitgitgadget
Previous: Johannes Schindelin via GitGitGadgetNext: Eric Sunshine
Message 2 of 6 in “Fix incorrectly reported CPU in 32-bit Windows”
  1. 0/1 Fix incorrectly reported CPU in 32-bit WindowsJohannes Schindelin via GitGitGadget, Feb 7, 2019
  2. 1/1 mingw: fix CPU reporting in `git version --build-options`Johannes Schindelin via GitGitGadget, Feb 7, 2019
  3. Eric SunshineFeb 8, 2019
  4. Johannes SchindelinFeb 13, 2019
  5. Junio C HamanoFeb 7, 2019
  6. Johannes SchindelinFeb 7, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.