git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] is_submodule_modified(): clear environment properly

From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date
Feb 24, 2010, 06:43 UTC
Message-ID
<cb7bb73a1002232243w2f5f63bcw45662bb80cb9e52@mail.gmail.com>
In-Reply-To
<7veikbjokw.fsf@alter.siamese.dyndns.org>
On Wed, Feb 24, 2010 at 4:32 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 15 quoted lines
> Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:
>
>> On Tue, Feb 23, 2010 at 10:47 PM, Jens Lehmann <Jens.Lehmann@web.de> wrote:
>>> Only GIT_INDEX_FILE was cleared until now, but other environment variables
>>> have to be cleared too before running git status in a submodule.
>>>
>> Of course this third use-case has a difference in that GIT_DIR is
>> actually set to something else and not just cleared, but this
>> particular case could just deep-copy the array modifying the
>> appropriate entry.
>
> Something like this, I guess.
>
> It is a bit frustrating that local_repo_env[] is a NULL terminated array
> and we cannot use ARRAY_SIZE(local_repo_env) as a compile-time constant.

I have a very simple solution for this, coming in the next revision of my patchset, together with the environment.c move

-- 
Giuseppe "Oblomov" Bilotta
Previous: Junio C Hamano
Message 4 of 4 in “is_submodule_modified(): clear environment properly”
  1. is_submodule_modified(): clear environment properlyJens Lehmann, Feb 23, 2010
  2. Giuseppe BilottaFeb 23, 2010
  3. Junio C HamanoFeb 24, 2010
  4. Giuseppe BilottaFeb 24, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.